Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase diff threshold for histogram unwrap tests #201

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nvaytet
Copy link
Member

@nvaytet nvaytet commented Feb 27, 2025

Fixes #200

@nvaytet nvaytet requested a review from jl-wynen February 27, 2025 08:39
@jl-wynen
Copy link
Member

I'd like to understand how the results can be different between runs if you seed the rng. Did you check whether the code uses an unseeded rng somewhere? Or maybe the problem is caused by parallelism?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flaky unwrapping tests
2 participants