Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flaky unwrapping tests #200

Open
jl-wynen opened this issue Feb 27, 2025 · 1 comment · May be fixed by #201
Open

Flaky unwrapping tests #200

jl-wynen opened this issue Feb 27, 2025 · 1 comment · May be fixed by #201
Assignees
@nvaytet

Comments

@jl-wynen
Copy link
Member

Some frame unwrapping tests can randomly fail. I observed it locally with these tests:

tests/time_of_flight/unwrap_test.py:179 test_standard_unwrap_histogram_mode[tof-80.0]
tests/time_of_flight/unwrap_test.py:179 test_standard_unwrap_histogram_mode[time_of_flight-80.0]

The reported problem is

>       assert np.nanpercentile(diff.values, percentile) < diff_threshold
E       assert np.float64(0.3026880000000014) < 0.3
@nvaytet nvaytet moved this from Triage to In progress in Development Board Feb 27, 2025
@nvaytet nvaytet self-assigned this Feb 27, 2025
@nvaytet
Copy link
Member

nvaytet commented Feb 27, 2025

I thought I had set seeds everywhere to make sure that didn't happen...

@nvaytet nvaytet linked a pull request Feb 27, 2025 that will close this issue
Open
@MridulS MridulS mentioned this issue Feb 27, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nvaytet nvaytet

Labels
None yet
Projects
Development Board
Status: In progress
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Increase diff threshold for histogram unwrap tests scipp/essreduce
2 participants
@jl-wynen @nvaytet