InitialSolution #31
Merged
InitialSolution #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #31 +/- ##
==========================================
- Coverage 97.59% 95.62% -1.97%
==========================================
Files 9 10 +1
Lines 166 183 +17
Branches 39 48 +9
==========================================
+ Hits 162 175 +13
Misses 3 3
- Partials 1 5 +4
|
include/scippp/initial_solution.hpp
Outdated
| class InitialSolution { | ||
| friend class Model; | ||
| //! Variable assignment in the initial solution. | ||
| std::map<SCIP_Var*, double> m_values {}; |
There was a problem hiding this comment.
#28 plans to make Var.var private in the future. I suppose Model would be a friend class, but InitialSolutions shouldn't have a reference to SCIP_Var. It should be easy to change this to Var*
There was a problem hiding this comment.
Good idea, changed to const Var*
kahessler
reviewed
Jan 9, 2025
kahessler
approved these changes
Jan 9, 2025
TonyCongqianWang
approved these changes
Jan 10, 2025
There was a problem hiding this comment.
Should this be in it's own separate PR?
There was a problem hiding this comment.
It could be. Seems to be more overhead to fix the pipeline somewhere else, merge, rebase .... instead of doing it on the fly here :-)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #30