Skip to content

fix assert_solved #132

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 2, 2019
Merged

fix assert_solved #132

merged 1 commit into from
Sep 2, 2019
+2 −2

Conversation

rschwarz
Copy link
Collaborator

@rschwarz rschwarz commented Sep 2, 2019

  • use SCIPgetStatus instead of SCIPgetStage
  • use tuple of stages instead of array (avoid alloc)

@rschwarz
fix assert_solved
dd9d121 
 - use `SCIPgetStatus` instead of `SCIPgetStage`
 - use tuple of stages instead of array (avoid alloc)
@rschwarz
Copy link
Collaborator Author

rschwarz commented Sep 2, 2019

fix #128

(which was already mostly fixed after merge of #109, but still had a typo)

@rschwarz rschwarz merged commit 4eb528b into master Sep 2, 2019
@rschwarz rschwarz deleted the rs/assert_solved branch September 2, 2019 20:45
@codecov
Copy link

codecov bot commented Sep 2, 2019

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   17.72%   17.72%           
=======================================
  Files         138      138           
  Lines        4377     4377           
=======================================
  Hits          776      776           
  Misses       3601     3601
Impacted Files Coverage Δ
src/MOI_wrapper/results.jl 97.14% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd77c0...dd9d121. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Sep 2, 2019 •
edited
Loading

Codecov Report

Merging #132 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #132   +/-   ##
=======================================
  Coverage   17.72%   17.72%           
=======================================
  Files         138      138           
  Lines        4377     4377           
=======================================
  Hits          776      776           
  Misses       3601     3601
Impacted Files Coverage Δ
src/MOI_wrapper/results.jl 97.14% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9dd77c0...dd9d121. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@rschwarz