private/app/flag: improve error handling when resolving SCION environment#4924
Open
oncilla wants to merge 1 commit into
Open
private/app/flag: improve error handling when resolving SCION environment#4924oncilla wants to merge 1 commit into
oncilla wants to merge 1 commit into
Conversation
…ment Previously, we would fall back to returning the default SCION daemon address, even if the user provided obviously wrong values. E.g., no --isd-as flag set, but multiple ASes in the environment file without a default. We are a bit more strict and now only return the default if no user input is given.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, we would fall back to returning the default SCION daemon address, even if the user provided obviously wrong values. E.g., no --isd-as flag set, but multiple ASes in the environment file without a default.
We are a bit more strict and now only return the default if no user input is given.