Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Cast non-hashable types to floats in toms748_scan #2467

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

test: Add backend support to testing

e815612
Select commit
Loading
Failed to load commit list.
Open

fix: Cast non-hashable types to floats in toms748_scan #2467

test: Add backend support to testing
e815612
Select commit
Loading
Failed to load commit list.
codefactor.io / CodeFactor failed Apr 18, 2024 in 1s

16 issues found.

Annotations

Check notice on line 84 in tests/test_infer.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/test_infer.py#L84 

unresolved comment '# FIXME: Remove float cast after TensorFlow support removed' (C100)

Check notice on line 149 in tests/test_infer.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/test_infer.py#L149 

unresolved comment '# FIXME: Remove float cast after TensorFlow support removed' (C100)

Check notice on line 83 in src/pyhf/infer/intervals/upper_limits.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/pyhf/infer/intervals/upper_limits.py#L83 

unresolved comment '# FIXME: scipy.optimize.toms748 still operates on floats,' (C100)

Check notice on line 76 in tests/test_infer.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/test_infer.py#L76 

unresolved comment '# FIXME: Remove float cast after TensorFlow support removed' (C100)

Check notice on line 164 in tests/test_infer.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/test_infer.py#L164 

unresolved comment '# FIXME: Can use expected_limits == pytest.approx([...]) after TensorFlow support removed' (C100)

Check notice on line 120 in tests/test_infer.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/test_infer.py#L120 

unresolved comment '# FIXME: Can use expected_limits == pytest.approx([...]) after TensorFlow support removed' (C100)

Check notice on line 208 in src/pyhf/infer/intervals/upper_limits.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

src/pyhf/infer/intervals/upper_limits.py#L208 

unresolved comment '# TODO: Can use `.T` after TensorFlow support is removed.' (C100)

Check notice on line 131 in tests/test_infer.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/test_infer.py#L131 

unresolved comment '# FIXME: Can use expected_limits == pytest.approx([...]) after TensorFlow support removed' (C100)

Check notice on line 179 in tests/test_infer.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/test_infer.py#L179 

unresolved comment '# FIXME: Can use expected_limits == pytest.approx([...]) after TensorFlow support removed' (C100)

Check notice on line 56 in tests/test_infer.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/test_infer.py#L56 

unresolved comment '# FIXME: Remove float cast after TensorFlow support removed' (C100)

Check notice on line 162 in tests/test_infer.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/test_infer.py#L162 

unresolved comment '# FIXME: Remove float cast after TensorFlow support removed' (C100)

Check notice on line 118 in tests/test_infer.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/test_infer.py#L118 

unresolved comment '# FIXME: Remove float cast after TensorFlow support removed' (C100)

Check notice on line 103 in tests/test_infer.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/test_infer.py#L103 

unresolved comment '# FIXME: Remove float cast after TensorFlow support removed' (C100)

Check notice on line 129 in tests/test_infer.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/test_infer.py#L129 

unresolved comment '# FIXME: Remove float cast after TensorFlow support removed' (C100)

Check notice on line 151 in tests/test_infer.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/test_infer.py#L151 

unresolved comment '# FIXME: Can use expected_limits == pytest.approx([...]) after TensorFlow support removed' (C100)

Check notice on line 177 in tests/test_infer.py

See this annotation in the file changed.

@codefactor-io codefactor-io / CodeFactor

tests/test_infer.py#L177 

unresolved comment '# FIXME: Remove float cast after TensorFlow support removed' (C100)
View more details on codefactor.io