fix: modified tick labels to read mpl ticks labels not positions (#498)

* fix: modified tick labels to read mpl ticks labels not positions * ci: update tests * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
scikit-hep · May 3, 2024 · 6737379 · 6737379
1 parent f6c9542
commit 6737379
Show file tree

Hide file tree

Showing 29 changed files with 11 additions and 3 deletions.
diff --git a/src/mplhep/plot.py b/src/mplhep/plot.py
@@ -424,7 +424,13 @@ def iterable_not_string(arg):
                     **_kwargs,
                 )
                 _e_leg = ax.errorbar(
-                    [], [], yerr=1, xerr=None, color=_s.get_edgecolor(), label=_label, linestyle=_ls
+                    [],
+                    [],
+                    yerr=1,
+                    xerr=None,
+                    color=_s.get_edgecolor(),
+                    label=_label,
+                    linestyle=_ls,
                 )
             return_artists.append(
                 StairsArtists(
@@ -545,7 +551,7 @@ def iterable_not_string(arg):
             )
 
     elif flow == "show" and (underflow > 0.0 or overflow > 0.0):
-        xticks = ax.get_xticks().tolist()
+        xticks = [label.get_text() for label in ax.get_xticklabels()]
         lw = ax.spines["bottom"].get_linewidth()
         _edges = plottables[0].edges
         _centers = plottables[0].centers
@@ -556,6 +562,7 @@ def iterable_not_string(arg):
         if underflow > 0.0:
             xticks[0] = ""
             xticks[1] = f"<{flow_bins[2]}"
+            ax.set_xticks(ax.get_xticks())
             ax.set_xticklabels(xticks)
 
             ax.plot(
@@ -582,6 +589,7 @@ def iterable_not_string(arg):
         if overflow > 0.0:
             xticks[-1] = ""
             xticks[-2] = f">{flow_bins[-3]}"
+            ax.set_xticks(ax.get_xticks())
             ax.set_xticklabels(xticks)
             ax.plot(
                 [_edges[-2], _edges[-1]],

diff --git a/tests/baseline/test_hist2dplot.png b/tests/baseline/test_hist2dplot.png
diff --git a/tests/baseline/test_hist2dplot_cbar_False.png b/tests/baseline/test_hist2dplot_cbar_False.png
diff --git a/tests/baseline/test_hist2dplot_cbar_True.png b/tests/baseline/test_hist2dplot_cbar_True.png
diff --git a/tests/baseline/test_hist2dplot_cbar_subplots.png b/tests/baseline/test_hist2dplot_cbar_subplots.png
diff --git a/tests/baseline/test_hist2dplot_custom_labels.png b/tests/baseline/test_hist2dplot_custom_labels.png
diff --git a/tests/baseline/test_hist2dplot_flow.png b/tests/baseline/test_hist2dplot_flow.png
diff --git a/tests/baseline/test_hist2dplot_hist_all_flow_hint.png b/tests/baseline/test_hist2dplot_hist_all_flow_hint.png
diff --git a/tests/baseline/test_hist2dplot_hist_all_flow_show.png b/tests/baseline/test_hist2dplot_hist_all_flow_show.png
diff --git a/tests/baseline/test_hist2dplot_inputs_nobin.png b/tests/baseline/test_hist2dplot_inputs_nobin.png
diff --git a/tests/baseline/test_histplot.png b/tests/baseline/test_histplot.png
diff --git a/tests/baseline/test_histplot_density.png b/tests/baseline/test_histplot_density.png
diff --git a/tests/baseline/test_histplot_flow.png b/tests/baseline/test_histplot_flow.png
diff --git a/tests/baseline/test_histplot_hist_flow_no_variances.png b/tests/baseline/test_histplot_hist_flow_no_variances.png
diff --git a/tests/baseline/test_histplot_hist_flow_variances.png b/tests/baseline/test_histplot_hist_flow_variances.png
diff --git a/tests/baseline/test_histplot_kwargs.png b/tests/baseline/test_histplot_kwargs.png
diff --git a/tests/baseline/test_histplot_multiple.png b/tests/baseline/test_histplot_multiple.png
diff --git a/tests/baseline/test_histplot_real.png b/tests/baseline/test_histplot_real.png
diff --git a/tests/baseline/test_histplot_stack.png b/tests/baseline/test_histplot_stack.png
diff --git a/tests/baseline/test_histplot_type_flow.png b/tests/baseline/test_histplot_type_flow.png
diff --git a/tests/baseline/test_histplot_types.png b/tests/baseline/test_histplot_types.png
diff --git a/tests/baseline/test_histplot_uproot_flow.png b/tests/baseline/test_histplot_uproot_flow.png
diff --git a/tests/baseline/test_histplot_w2.png b/tests/baseline/test_histplot_w2.png
diff --git a/tests/baseline/test_log.png b/tests/baseline/test_log.png
diff --git a/tests/baseline/test_onebin_hist.png b/tests/baseline/test_onebin_hist.png
diff --git a/tests/baseline/test_simple.png b/tests/baseline/test_simple.png
diff --git a/tests/baseline/test_simple2d.png b/tests/baseline/test_simple2d.png
diff --git a/tests/baseline/test_simple_xerr.png b/tests/baseline/test_simple_xerr.png
diff --git a/tests/test_mock.py b/tests/test_mock.py
@@ -57,7 +57,7 @@ def test_simple(mock_matplotlib):
         approx([]),
         yerr=1,
         xerr=None,
-        linestyle='-',
+        linestyle="-",
         color=ax.stairs().get_edgecolor(),
         label="X",
     )