Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix typo in definition of constituents (pt instead of p) #326

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

chrispap95
Copy link
Collaborator

Very trivial change. The input of constituents() is supposed to be min_pt not min_p. When naming the input argument, it causes issues with static code analyzers and type checkers.

@matthewfeickert matthewfeickert changed the title Fix typo in definition of constituents (pt instead of p) fix: Fix typo in definition of constituents (pt instead of p) Dec 2, 2024
@matthewfeickert
Copy link
Member

@chrispap95 Thanks for the catch. Assuming this is the only place this occurs, feel free to merge whenever. 👍

@chrispap95
Copy link
Collaborator Author

@matthewfeickert the code runs fine when you call it as: constituents(min_pt=150) (this is how we had it in our analysis code). I assume the reason it works is because this function is just a placeholder(?). I caught it because Pylance was complaining about it. All the other functions are defined with min_pt as far as I can tell. Will merge and we can fix any other issues in a separate PR (if found).

@chrispap95 chrispap95 merged commit 10f8bc8 into scikit-hep:main Dec 2, 2024
12 of 13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants