Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Use build-system pybind11 over Git submodule #313

Merged
merged 2 commits into from
Sep 16, 2024
Merged

build: Use build-system pybind11 over Git submodule #313

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bf44f7a
build: Add support for NumPy 2.0 wheels
matthewfeickert Sep 12, 2024
5e5bcd7
ci: List Python packages installed before testing
matthewfeickert Sep 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@ jobs:
echo $PATH
python -m pip install '.[test]' -v

- name: List installed Python packages
run: python -m pip list

- name: Test package
run: python -m pytest -vv -rs -Wd

Expand Down
3 changes: 0 additions & 3 deletions .gitmodules
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
[submodule "fastjet"]
path = extern/fastjet-core
url = https://gitlab.com/fastjet/fastjet.git
[submodule "pybind11"]
path = pybind11
url = https://github.com/pybind/pybind11.git
[submodule "fastjet-contrib"]
path = extern/fastjet-contrib
url = https://github.com/cms-externals/fastjet-contrib.git
1 change: 0 additions & 1 deletion MANIFEST.in
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
graft src
graft tests
graft extern
graft pybind11
global-exclude .git .gitmodules
include LICENSE README.md pyproject.toml setup.py setup.cfg patch_clustersequence.txt
exclude .cirrus.yml
1 change: 0 additions & 1 deletion pybind11
Open in desktop
Submodule pybind11 deleted from 8a099e
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
requires = [
"setuptools>=42",
"setuptools_scm[toml]>=3.4",
"pybind11>=2.6.1",
"pybind11>=2.12.0",
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this isn't really necessary(?) to bump it given that there's already a lower bound here, but I guess signaling this also doesn't hurt.

]
build-backend = "setuptools.build_meta"

Expand Down
Loading