fix: Add patch to add .Makefile.inc to fastjet-contrib #275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* As each contribution in fastjet-contrib has their own Makefile which defines CXX and CXXFLAGS it is necessary to use a globally used .Makefile.inc to change these everywhere. For fastjet to be able to control the values from the environment that fastjet is being built in, use a .Makefile.inc patch to undefine CXX and CXXFLAGS for Make. This allows for the environment varaibles to be picked up. * Remove patch_makefilein.txt as patch_makefileinc.txt supreceeds it.
lgray
force-pushed
the
fix/add-additional-patch-for-fastjet-contrib
branch
from
f7df4b5 to
3760f63
Compare
|
Thanks for the fast review @lgray! |
This was referenced Feb 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fastjet-contribhas their ownMakefilewhich definesCXXandCXXFLAGSit is necessary to use a globally used.Makefile.incto change these everywhere. Forfastjetto be able to control the values from the environment thatfastjetis being built in, use a.Makefile.incpatch to undefineCXXandCXXFLAGSforMake. This allows for the environment varaibles to be picked up.patch_makefilein.txtaspatch_makefileinc.txtsupreceeds it.Amends PR #191 and is needed for conda-forge/staged-recipes#21052