Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: explicitly convert parameter bounds to list of tuples #471

Merged
merged 2 commits into from
Mar 24, 2024

Conversation

alexander-held
Copy link
Member

A bug fix in typeguard 4.2.0 started flagging a type inconsistency where model.config.suggested_bounds() contains elements that are lists instead of tuples with custom parameter bound configuration, see scikit-hep/pyhf#2462. This fix here works around this by explicitly converting to a list of tuples for further use within cabinetry.

If the behavior in pyhf changes, this should be reverted / adjusted in the future.

* convert parameter bounds to list of tuples for consistent types when custom bounds are used

Copy link

codecov bot commented Mar 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (f116d4e) to head (768074e).

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #471   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           22        22           
  Lines         2093      2093           
  Branches       344       346    +2     
=========================================
  Hits          2093      2093           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alexander-held alexander-held merged commit 9aa0447 into master Mar 24, 2024
7 checks passed
@alexander-held alexander-held deleted the fix/par-bounds-type branch March 24, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant