Skip to content

Fix a typo in a column-name of the platform-machine table #1096

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 5, 2025

Conversation

mabruzzo
Copy link
Contributor

@mabruzzo mabruzzo commented Jun 2, 2025

Fix a typo in a column-name of the platform-machine table

Copy link
Collaborator

@LecrisUT LecrisUT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could also be platform.machine() to be more explicit that that is the output of calling that function since platform-machine is an "arbitrary" string input.

Do you also want to fix a nitpick Intel 64-bit -> Intel/AMD 64-bit for linux ? (not sure for the Windows row though)

@LecrisUT
Copy link
Collaborator

LecrisUT commented Jun 2, 2025

Sorry, I should have been explicit Intel (32|64)-bit -> Intel/AMD (32|64)-bit for the linux rows

@mabruzzo
Copy link
Contributor Author

mabruzzo commented Jun 2, 2025

Do you also want to fix a nitpick Intel 64-bit -> Intel/AMD 64-bit for linux ? (not sure for the Windows row though)

Yup, just pushed that change.

Could also be platform.machine() to be more explicit that that is the output of calling that function since platform-machine is an "arbitrary" string input

FYI, I was following the conventions of the platform-system table. I'm happy to make the change, but do you want me to also make the corresponding change to the platform-system table?

@LecrisUT
Copy link
Collaborator

LecrisUT commented Jun 2, 2025

FYI, I was following the conventions of the platform-system table. I'm happy to make the change, but do you want me to also make the corresponding change to the platform-system table?

Ah good point. I am not sure, particularly since I am not sure if it would match it since it has a w/o suffix note. @henryiii thoughts on this?

@henryiii henryiii merged commit 0a29cc1 into scikit-build:main Jun 5, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants