Skip to content

feat: use 1.12.1 from Kitware fork #305

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

feat: use 1.12.1 from Kitware fork #305

wants to merge 3 commits into from

Conversation

henryiii
Copy link
Contributor

@henryiii henryiii commented Jun 20, 2025

Let's release this first, see #245 and #302.

Ran nox -s bump -- --upstream-repository Kitware/ninja.

Interesting, this includes a new feature branch, msvc-depfile. We will loose this new addition upgrading to 1.13.0.

There doesn't seem to be a release with binaries yet.

@jcfr
Copy link
Contributor

jcfr commented Jun 20, 2025

Interesting, this includes a new feature branch, msvc-depfile. We will loose this new addition upgrading to 1.13.0.

I just shared feedback with the CMake team explaining the situation.

In a nutshell, I mentioned it would be ideal to update the Kitware fork based of version 1.13 while also integrating the following features:

  • make-4.3-jobserver-1: Based on this release, which includes pipe-based jobserver support for Make 4.3 and was conveniently created by the same developer who upstreamed jobserver support
  • msvcdepfile-1: Adds Windows-specific support for parsing MSVC dependency files. See PR #2600

I will follow-up once we discussed it and settle on a path forward.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants