Add interface compatibility spec#5
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
ruby_llm now passes these keyword arguments to provider complete methods. Accept them for interface compatibility (not yet used by local models). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spec/ruby_llm/red_candle/interface_compatibility_spec.rbthat probes the real class/method surface of bothred-candleandruby_llm— no mocksCandle::LLM.from_pretrained,Candle::Device.cpu/.best,Candle::GenerationConfig.balanced, andCandle::Tokenizerare presentruby_llmprovider contract:Providerinherits correctly and includes#complete,#stream,#list_models;Message,Chunk, andModel::Infoaccept the keyword args the plugin passesWhy this matters
The existing test suite uses
MockCandleModeland stubs, so ifred-candleorruby_llmchange their public APIs, every mock-based test still passes while production breaks silently. This spec catches those breakages immediately.How it fits into CI
This spec is designed to run in the daily version-check cron job. When a new upstream release lands, these interface probes fail with self-explanatory messages (e.g., "Candle::GenerationConfig.balanced is missing — red-candle API may have changed"), giving us early warning before users hit runtime errors.
Test plan
bundle exec rspec spec/ruby_llm/red_candle/interface_compatibility_spec.rb— 13 examples, 0 failures🤖 Generated with Claude Code