Feat search #735

Bashamega · 2025-03-08T07:37:07Z

Fix #673
I have added the search input

netlify · 2025-03-08T07:37:25Z

✅ Deploy Preview for scientific-python-org ready!

Built without sensitive environment variables

Name	Link
🔨 Latest commit	`c010a96`
🔍 Latest deploy log	https://app.netlify.com/sites/scientific-python-org/deploys/67d115db85063c0008bfb2d6
😎 Deploy Preview	https://deploy-preview-735--scientific-python-org.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.
Lighthouse	1 paths audited Performance: 97 Accessibility: 100 Best Practices: 100 SEO: 100 PWA: - View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify site configuration.

Bashamega · 2025-03-08T08:43:22Z

pre-commit.ci autofix

…-python.org into feat-search

jarrodmillman · 2025-03-09T07:08:55Z

Can you use the theme search feature?

Bashamega · 2025-03-09T08:15:24Z

Can you use the theme search feature?

Sure, thank you for your help

Bashamega · 2025-03-09T10:33:22Z

Hello @jarrodmillman
Thank you so much for the linked pr, it has helped me solve the issue.
The build is now working. Please review and merge

jarrodmillman · 2025-03-10T14:15:28Z

You should use the css and javascript from the theme. If you need improvements, it should be done there. I also don't think you need to edit the netlify config.

Bashamega · 2025-03-10T14:27:23Z

You should use the css and javascript from the theme. If you need improvements, it should be done there. I also don't think you need to edit the netlify config.

I need to add the NODE to the netlify environment to install the pagfind library.

stefanv · 2025-03-10T22:42:26Z

assets/css/search.css

@@ -0,0 +1,26 @@
+.search-button {


This should already be part of the theme?

stefanv · 2025-03-10T22:42:39Z

assets/js/search.js

@@ -0,0 +1,123 @@
+// This file is attributed to the Scientific Python Developers


As should this be.

stefanv · 2025-03-10T22:43:04Z

config.yaml

@@ -20,7 +20,7 @@ params:
  author:
    name: Scientific Python team
  description: Community developed and owned ecosystem for scientific computing
-
+  search: true


This should be enough to pull in the JS and CSS from the theme.

stefanv · 2025-03-10T22:43:29Z

netlify.toml

@@ -1,7 +1,8 @@
 [build.environment]
  PYTHON_VERSION = "3.13"
-  HUGO_VERSION = "0.141.0"
-  DART_SASS_VERSION = "1.83.4"
+  HUGO_VERSION = "0.142.0"


Leave these alone, for another PR.

jarrodmillman · 2025-03-10T23:17:09Z

netlify.toml

-  HUGO_VERSION = "0.141.0"
-  DART_SASS_VERSION = "1.83.4"
+  HUGO_VERSION = "0.142.0"
+  NODE_VERSION = "20"


Also, please remove the node version. This is handled on the netlify site.

jarrodmillman · 2025-03-11T00:10:29Z

You should use the css and javascript from the theme. If you need improvements, it should be done there. I also don't think you need to edit the netlify config.

I need to add the NODE to the netlify environment to install the pagfind library.

We are already using Node 20.

jarrodmillman · 2025-03-11T17:40:05Z

Makefile

@@ -55,12 +55,18 @@ content/specs/core-projects/core-projects.json: content/specs/core-projects/[^_]
 	@python tools/md-header-to-json.py $? > $@

 html: prepare calendars core-project-json ## build the website in ./public
+	hugo --themesDir="./themes";


You should be able to just add:

hugo; $(SEARCH)

to the prepare target and remove it everywhere else. (I also removed the --themesDir option.

stefanv · 2025-03-12T04:48:23Z

Makefile

@@ -2,7 +2,6 @@
 .DEFAULT_GOAL := help
 SHELL:=/bin/bash

-


Remove unrelated edit.

Bashamega · 2025-03-12T05:05:26Z

Hello @jarrodmillman, and @stefanv
I have updated the Makefile as requested

stefanv

Thanks @Bashamega!

Bashamega added 3 commits March 8, 2025 07:31

feat: integrate search

a3e6722

feat: netlify

43fcafd

patch: node version

cda79c4

Bashamega added 3 commits March 8, 2025 07:41

patch: remove my netlify configurations

455a721

patch: install missing package

6c7061b

fix: command

cf7d2d1

pre-commit-ci bot and others added 4 commits March 8, 2025 08:43

[pre-commit.ci 🤖] Apply code format tools to PR

2fb5a88

fix: environment

3c50e97

Merge branch 'feat-search' of https://github.com/Bashamega/scientific…

a5ebfa9

…-python.org into feat-search

Fix

079bc44

Bashamega added 4 commits March 9, 2025 10:05

fix the makefile and netlify deployment

c8b4bb0

chore: environment fixes

70e28fd

chore: bump sass version

6c60d7f

chore:fix theme dir

58727d1

stefanv reviewed Mar 10, 2025

View reviewed changes

jarrodmillman reviewed Mar 10, 2025

View reviewed changes

Bashamega added 4 commits March 11, 2025 06:22

Delete assets/js/search.js

8895aab

Delete assets/css/search.css

d134217

Undo netlify changes

fdd6334

Merge branch 'main' into feat-search

30291ea

Bashamega requested a review from stefanv March 11, 2025 04:26

Bashamega requested a review from jarrodmillman March 11, 2025 04:26

jarrodmillman reviewed Mar 11, 2025

View reviewed changes

Merge branch 'main' into feat-search

5fe1717

stefanv reviewed Mar 12, 2025

View reviewed changes

Makefile Outdated

@@ -2,7 +2,6 @@

.DEFAULT_GOAL := help

SHELL:=/bin/bash

Copy link

Member

stefanv Mar 12, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove unrelated edit.

Bashamega added 2 commits March 12, 2025 05:02

chore: modify the makefile

29236e2

chore: remove the hugo theme dir

c010a96

stefanv approved these changes Mar 12, 2025

View reviewed changes

Bashamega requested a review from jarrodmillman March 19, 2025 07:07

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Feat search #735

Feat search #735

Bashamega commented Mar 8, 2025

netlify bot commented Mar 8, 2025 •

edited

Loading

Bashamega commented Mar 8, 2025

jarrodmillman commented Mar 9, 2025

Bashamega commented Mar 9, 2025

Bashamega commented Mar 9, 2025

jarrodmillman commented Mar 10, 2025 •

edited

Loading

Bashamega commented Mar 10, 2025

stefanv Mar 10, 2025

Bashamega Mar 11, 2025

stefanv Mar 10, 2025

Bashamega Mar 11, 2025

stefanv Mar 10, 2025

stefanv Mar 10, 2025

jarrodmillman Mar 10, 2025

jarrodmillman commented Mar 11, 2025

jarrodmillman Mar 11, 2025

stefanv Mar 12, 2025

Bashamega commented Mar 12, 2025

stefanv left a comment

		@@ -0,0 +1,123 @@
		// This file is attributed to the Scientific Python Developers

Feat search #735

Are you sure you want to change the base?

Feat search #735

Conversation

Bashamega commented Mar 8, 2025

netlify bot commented Mar 8, 2025 • edited Loading

✅ Deploy Preview for scientific-python-org ready!

Bashamega commented Mar 8, 2025

jarrodmillman commented Mar 9, 2025

Bashamega commented Mar 9, 2025

Bashamega commented Mar 9, 2025

jarrodmillman commented Mar 10, 2025 • edited Loading

Bashamega commented Mar 10, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jarrodmillman commented Mar 11, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Bashamega commented Mar 12, 2025

stefanv left a comment

Choose a reason for hiding this comment

netlify bot commented Mar 8, 2025 •

edited

Loading

jarrodmillman commented Mar 10, 2025 •

edited

Loading