-
Notifications
You must be signed in to change notification settings - Fork 3
feature: upgrade to use udp unicast #73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I have been doing some testing with this branch and the SciFi UDP unicast branch. A pain point I noticed is the inclusion of a destination IP in the config means that configs are not host-agnostic. If I change wireless networks or want to share the config to someone else, the destination IP needs to be updated. Perhaps the CLI can handle setting this field to the local IP address? Ill wait till you are ready for review for any other comments. |
35caa8b
to
449d7ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This overall looks like its working properly. I have a few comments:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
1996bf1
to
d091845
Compare
12297dd
to
5cc822c
Compare
Summary
In preparation for switching to UDP unicast, we have updated the StreamOut configuration to support udp unicast
Changes
Migration
StreamOut configurations can just be defined like this (with an empty configuration for stream_out)
The client will automatically fill with the clients IP and a default streaming port. You can also set a different port yourself, like this:
Specific IP addresses will not work, unless it is your own. In most cases, just let the client figure out the correct IP/Port to use.
Testing