Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: add setup.sh en lieu of Makefile #68

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

antoniaelsen
Copy link
Collaborator

@antoniaelsen antoniaelsen commented Mar 1, 2025

for Windows support

@antoniaelsen antoniaelsen requested a review from gilbert-sci March 1, 2025 04:22
@antoniaelsen antoniaelsen marked this pull request as ready for review March 5, 2025 08:26
@antoniaelsen antoniaelsen linked an issue Mar 5, 2025 that may be closed by this pull request
Copy link
Collaborator

@gilbert-sci gilbert-sci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly just an update to the docs

./setup.sh test

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit newline

generate
;;
*)
echo "Usage: $0 {clean|generate|test|all}"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this generate helper doesn't take arguments anymore.

;;
esac

exit 0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: newline

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migrate to shell script from Makefile for Windows support
2 participants