Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix two CI regressions (new beta toolchain lint and unmaintained crate advisory) #438

Merged
merged 2 commits into from
Nov 12, 2024
Merged

Fix two CI regressions (new beta toolchain lint and unmaintained crate advisory) #438

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
697cbdb
Let cargo-deny ignore that the instant crate is unmaintained
ammernico Nov 11, 2024
1e76d47
Add a lifetime to the return type in search_packages
ammernico Nov 11, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions deny.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,11 @@ ignore = [
# https://github.com/trishume/syntect/issues/537 is resolved (replace
# yaml-rust with yaml-rust2):
{ id = "RUSTSEC-2024-0320", reason = "Only an informative advisory that the crate is unmaintained and the maintainer unreachable" },

# Ignore an "INFO Unmaintained" advisory for the instant crate
# that the "indicatif" crate uses. This can be removed once
# https://github.com/console-rs/indicatif/issues/665 is resolved
# (The dependency instant is no longer maintained -
# consider switching to web-time instead):
{ id = "RUSTSEC-2024-0384", reason = "Only an informative advisory that the crate is unmaintained and the author recommends using the maintained web-time crate instead." },
]
2 changes: 1 addition & 1 deletion src/repository/repository.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,7 +277,7 @@ impl Repository {
pname: &'a Option<PackageName>,
pvers: &'a Option<PackageVersionConstraint>,
matching_regexp: &'a Option<Regex>,
) -> Result<impl Iterator<Item = &Package> + 'a> {
) -> Result<impl Iterator<Item = &'a Package> + 'a> {
let mut r = self.inner.values()
.filter(move |p| {
match (pname, pvers, matching_regexp) {
Expand Down