Implement package filtering as a repo method #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Moved the package filtering logic from `download` and `verify` functions into a new `search_packages` method in the `Repository` struct. - Updated `download` and `verify` functions to use the new `search_packages` method. This refactor improves code reuse and readability by centralizing the package filtering logic. Fixes science-computing#428 We already fixed this for the download function in 76a3cde. The package filtering for the verifying function was implemented in the same way but didn't fail yet. Signed-off-by: Nico Steinle <[email protected]>
ammernico
added
the
prerelease
primeos-work
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
downloadandverifyfunctions into a newsearch_packagesmethod in theRepositorystruct.downloadandverifyfunctions to use the newsearch_packagesmethod.This refactor improves code reuse and readability by centralizing the package filtering logic.
Fixes #428
We already fixed this for the download function in 76a3cde. The package filtering for the verifying function was implemented in the same way but didn't fail yet.