Skip to content

[Snyk] Security upgrade django from 3.2.25 to 4.2.28 #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robertatakenaka wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade django from 3.2.25 to 4.2.28 #821

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc1ca08
fix: requirements/production.txt to reduce vulnerabilities
snyk-bot Feb 5, 2026
dc05810
fix: requirements/production.txt to reduce vulnerabilities
snyk-bot Feb 8, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion requirements/production.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,5 @@ setuptools>=68.2.2 # not directly required, pinned by Snyk to avoid a vulnerabil

# Elastic-APM # https://pypi.org/project/elastic-apm/
# ------------------------------------------------------------------------------
elastic-apm==6.21.4.post8347027212
elastic-apm==6.21.4.post8347027212
django>=4.2.28 # not directly required, pinned by Snyk to avoid a vulnerability
Comment on lines +17 to +18
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change creates a conflicting Django version requirement. The base.txt file (which is included via -r base.txt on line 3) already specifies django==5.2.3. Adding django>=4.2.28 to production.txt will cause a dependency conflict since pip cannot satisfy both django==5.2.3 and django>=4.2.28 simultaneously (even though 5.2.3 is greater than 4.2.28, the exact version pin in base.txt takes precedence and conflicts).

The project is already using Django 5.2.3, which is significantly newer than 4.2.28 and should already include the security fixes that this PR aims to address. This PR appears to be based on outdated dependency information and is not needed.

Suggested change
elastic-apm==6.21.4.post8347027212
django>=4.2.28 # not directly required, pinned by Snyk to avoid a vulnerability
elastic-apm==6.21.4.post8347027212

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description states this upgrades Django from 3.2.25 to 4.2.28, but the codebase already has Django 5.2.3 specified in requirements/base.txt. This indicates that the Snyk scan may have been performed on outdated or incorrect dependency information. The project does not actually use Django 3.2.25, so this security upgrade is not applicable to the current state of the codebase.

Copilot uses AI. Check for mistakes.