Skip to content

[Snyk] Security upgrade django from 3.2.25 to 4.2.28 #820

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
robertatakenaka wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[Snyk] Security upgrade django from 3.2.25 to 4.2.28 #820

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3f85729
fix: requirements/local.txt to reduce vulnerabilities
snyk-bot Feb 5, 2026
171eea0
fix: requirements/local.txt to reduce vulnerabilities
snyk-bot Feb 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions requirements/local.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,3 +37,4 @@ django-extensions==3.2.3 # https://github.com/django-extensions/django-extensio
django-coverage-plugin==3.1.0 # https://github.com/nedbat/django_coverage_plugin
pytest-django==4.7.0 # https://github.com/pytest-dev/pytest-django
tornado>=6.4.1 # not directly required, pinned by Snyk to avoid a vulnerability
django>=4.2.28 # not directly required, pinned by Snyk to avoid a vulnerability
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change introduces a version conflict with the Django version already specified in base.txt. The base.txt file (which is included via -r base.txt on line 1) specifies django==5.2.3 on line 30, but this change adds django>=4.2.28.

This creates conflicting requirements:

  • base.txt requires exactly Django 5.2.3
  • local.txt now requires Django >= 4.2.28

Since Django 5.2.3 satisfies the >=4.2.28 constraint, pip might resolve this to Django 5.2.3, making this line redundant. However, this approach is confusing and can lead to maintenance issues.

The correct approach would be to update the Django version in base.txt to address the security vulnerability, rather than adding a conflicting requirement in local.txt. The security fix should apply to all environments (local, production, etc.), not just the local development environment.

Suggested change
django>=4.2.28 # not directly required, pinned by Snyk to avoid a vulnerability

Copilot uses AI. Check for mistakes.
Copy link

Copilot AI Feb 5, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The PR description mentions upgrading Django from 3.2.25 to 4.2.28, but the codebase actually has Django 5.2.3 specified in requirements/base.txt (line 30). This indicates a significant discrepancy between what the PR claims to do and the actual state of the codebase.

Either:

  1. The PR description is based on outdated information about the project's Django version, or
  2. There's confusion about which version is currently in use

The security vulnerability fix (SNYK-PYTHON-DJANGO-15183335) should be evaluated against Django 5.2.3, not 3.2.25, to determine if it's even necessary. Django 5.2.3 may already have the security fix that this PR is attempting to apply.

Copilot uses AI. Check for mistakes.