Fix rendering of empty extra_fields
div
#542
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
On accounts with no extra fields defined, the containing div was still rendering.
Example:
Fix:
In the original code, the if condition checked for defined labels and values, but the div still rendered even if no valid fields existed. Introduced
valid_fields
, a filtered list ofextra_fields
usingselectattr('value')
, which removes fields without valid values. This ensures only fields with both defined label and non-empty value are processed.Instead of just rendering the div based on the presence of any label/value, I added
valid_fields | length > 0
to check if any valid fields exist before rendering the div. This prevents rendering an empty div.Updated Screenshot: