Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Abstracted out the filter dialog so that you can easily supply your own #27

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Abstracted out the filter dialog so that you can easily supply your own #27

wants to merge 3 commits into from

Conversation

adarmus
Copy link
Collaborator

@adarmus adarmus commented Jan 5, 2017

No description provided.

adarmus added 2 commits January 5, 2017 16:59
@adarmus
Added ITextColumnFilterDialog
9558ff8 
This allows custom filter dialogs to be added in by inheriting from
TextColumnFilter
@adarmus
Made CanShow() virtual
a128ef3 
To allow customisation of the filtering method
@schoetbi schoetbi self-requested a review January 17, 2017 15:06
schoetbi
schoetbi reviewed Jan 17, 2017
View reviewed changes
Copy link
Owner

@schoetbi schoetbi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adarmus What do you think about 1137769. Whould this be ok?

@adarmus
Copy link
Collaborator Author

adarmus commented Jan 17, 2017

Yes, good idea

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@schoetbi schoetbi schoetbi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@adarmus @schoetbi