Skip to content

ci: cancel superseded PR runs with a concurrency group #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
spacedevin wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ci: cancel superseded PR runs with a concurrency group #32

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,13 @@ on:

pull_request:

# One live run per PR. A push to a PR branch cancels the run for the commit it just replaced —
# nobody reads that verdict, and the verify matrix it was still grinding through is ~250 billed
# minutes. Pushes to main are NEVER cancelled: the run on main is what cuts the prerelease and
# what chuggie.dev reads its ROM artifacts from, so a superseded one still has to finish.
concurrency:
group: ci-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

permissions:
contents: write
Expand Down
6 changes: 6 additions & 0 deletions .github/workflows/screenshot.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,12 @@ on:
- "scripts/screenshot.sh"
- ".github/workflows/screenshot.yml"

# Same rule as ci.yml: a push to the PR cancels the run for the commit it replaced. Written the same
# way as there (pull_request-only cancel) so the two stay in step if this ever gains a push trigger.
concurrency:
group: ci-${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

jobs:
screenshot:
runs-on: ubuntu-latest
Expand Down
Loading