feat: add optional path #293
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -155,13 +155,20 @@ const TAB_ID_TTL = 1000 * 60 * 60 * 24 * 30; | |||
| const globalWindow = () => window; | |||
|
|
|||
| /** | |||
| * Provides Identity functionalty to a web page | |||
| * Utils for Identity | |||
There was a problem hiding this comment.
wdyt about not exposing this? I don't think there's any reason to have this public, since it's used in Identity
There was a problem hiding this comment.
I know, but there is a problem with tests. It's used by private method so there is no good way to test this.
There was a problem hiding this comment.
I changed import source in tests and reverted export from main index file
aleksandra-miernik-stp
force-pushed
the
feat/CBT-13333/add-path
branch
from
dae47ce to
89badcb
Compare
aleksandra-miernik-stp
force-pushed
the
feat/CBT-13333/add-path
branch
from
89badcb to
32c1c07
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add optional path for Session Service Domain