Skip to content

Conversation

@zeyus
Copy link
Contributor

@zeyus zeyus commented Nov 4, 2025

I noticed my MacOS test runner failed because the number of resolved streams were less than expected (2 instead of 3) see action output: https://github.com/NexusDynamic/liblsl/actions/runs/19069877370/job/54469644449#step:11:605

-------------------------------------------------------------------------------
resolve multiple streams
-------------------------------------------------------------------------------
/Users/runner/work/liblsl/liblsl/testing/ext/discovery.cpp:9
...............................................................................

/Users/runner/work/liblsl/liblsl/testing/ext/discovery.cpp:20: FAILED:
  REQUIRE( resolver.results().size() == n )
with expansion:
  2 == 3

0.000 s: resolve multiple streams
0.000 s: multithreaded lsl_last_error

I checked the test to see why it was failing, and I saw that it checks the result, then sleeps to allow time for stream discovery then checks again, but if it fails the first check then the test will fail.

This fix just removes the first check and always waits.

@zeyus zeyus force-pushed the feature/test-delay-fix branch from cbe581e to 9986781 Compare November 5, 2025 11:14
@zeyus zeyus changed the base branch from dev to cboulay/apple_framework November 5, 2025 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant