(APPLE) Build a Universal Framework, and add code signing and notarization #237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cboulay
force-pushed
the
cboulay/cmake_cleanup
branch
from
8d2a332 to
c1d3ebe
Compare
…ast we don't get a big red X.
…ion that installed non-flat header tree by transitive dependencies.
…d for Ubuntu 18.04 which we no longer support)
…(temporarily disabled non apple runners for debugging)
cboulay
force-pushed
the
cboulay/apple_framework
branch
from
9202bd9 to
9531c43
Compare
…de_directories. :`(
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR attempts to build the lsl library as a (universal) framework instead of a dylib. The primary advantage of putting everything (library, headers, cmake files) inside a framework vs a folder is that it allows us to add entitlements for multicasting. From what I've read, this will make it easier for consumers of lsl.framework to enable multitasking and I hope this will fix some issues with Unity and Apple Vision Pro.
This one is going to take a while to get working on GHA I'm sure while I workout all the certificate and signing/notarizing steps.