feat: Add warning for nonexistent query conditions #155
Conversation
When querying for data using `EEGDashDataset`, if a user provides a filter value that does not exist in the dataset (e.g., a misspelled task name), the class would previously return an empty or incomplete dataset without any notification. This could lead to user confusion. This change introduces a warning mechanism that checks the user's query conditions against the fetched records. If any of the requested values for a given field do not match any records, a warning is logged to inform the user. This is implemented by: - Refactoring the `EEGDashDataset.__init__` method to fetch records before creating the dataset objects. - Adding a `_warn_for_unmatched_query_conditions` method to perform the validation. - Adding a new test suite in `tests/test_warnings.py` to verify the new warning functionality under various conditions.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. |
When querying for data using
EEGDashDataset, if a user provides afilter value that does not exist in the dataset (e.g., a misspelled
task name), the class would previously return an empty or incomplete
dataset without any notification. This could lead to user confusion.
This change introduces a warning mechanism that checks the user's query
conditions against the fetched records. If any of the requested values
for a given field do not match any records, a warning is logged to
inform the user.
This is implemented by:
EEGDashDataset.__init__method to fetch recordsbefore creating the dataset objects.
_warn_for_unmatched_query_conditionsmethod to performthe validation.
tests/test_warnings.pyto verify thenew warning functionality under various conditions.
PR created automatically by Jules for task 12458885612927622774