stored_projection: a field that is also assigned is not decided by its literals - #7
Merged
Merged
Conversation
alii
added a commit
to oven-sh/bun
that referenced
this pull request
Aug 14, 2026
Picks up scarletindustries/mordant#7 (a field that is also assigned is not a stored projection), which removes the ParseTask entry from the baseline. Regenerating the baseline also added one entry that has nothing to do with the bump: asymmetric_guard on the free_resources call #38044 added in h2_frame_parser.rs. Looked at it; freeing the stream on the transition to CLOSED is right whatever can_send_data reads, so it is baselined rather than changed. First time that lint has fired here, so keeping an eye on whether it earns its place. bun run rust:mordant is clean with the new pin and baseline.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6, the ParseTask half. There the Option field the lint paired with the enum is filled in after construction (task.ctx = Some(..) in two places), so the literals were never the whole story.
Any x.f = .. on a local struct now takes f out of the pairing for that struct. On bun this drops the ParseTask finding and keeps the other two.
The GetActiveCfg half of #6 is the lint working as described, just on a 2 site type, so nothing here for that.