Skip to content

Conversation

@benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Oct 22, 2025

Issue: CLDSRV-724

@codecov
Copy link

codecov bot commented Oct 22, 2025

❌ 4 Tests Failed:

Tests completed Failed Passed Skipped
6223 4 6219 0
View the top 3 failed test(s) by shortest run time
"after all" hook for "should list buckets"::GET Service - AWS.S3.listBuckets With default signature when user has credential "after all" hook for "should list buckets"
Stack Traces | 0s run time
s3.deleteBucket is not a function
"after all" hook for "should list buckets"::GET Service - AWS.S3.listBuckets With v4 signature when user has credential "after all" hook for "should list buckets"
Stack Traces | 0s run time
s3.deleteBucket is not a function
"before all" hook for "should list buckets concurrently"::GET Service - AWS.S3.listBuckets With default signature when user has credential "before all" hook for "should list buckets concurrently"
Stack Traces | 0s run time
s3.config.update is not a function
"before all" hook for "should list buckets concurrently"::GET Service - AWS.S3.listBuckets With v4 signature when user has credential "before all" hook for "should list buckets concurrently"
Stack Traces | 0s run time
s3.config.update is not a function

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-724-mdSearch-related-functional-tests branch 3 times, most recently from 063a9f4 to 296881d Compare October 28, 2025 14:10
@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-724-legacy-related-functional-tests branch 2 times, most recently from ab4a359 to db91a5a Compare October 28, 2025 14:34
@benzekrimaha benzekrimaha marked this pull request as ready for review October 28, 2025 14:35
@benzekrimaha benzekrimaha force-pushed the improvement/CLDSRV-724-legacy-related-functional-tests branch from 5b3a4ed to 67b5ecb Compare October 28, 2025 14:37
done();
'in the future', async () => {

// First, get a valid signed URL with maximum allowed expiry
Copy link
Contributor

@SylvainSenechal SylvainSenechal Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// First, get a valid signed URL with maximum allowed expiry
// First, get a valid signed URL with maximum allowed expiry of 7 days

then remove the other comment, or create a variable named 7daysInSec or something

Also the comment line 60 about the "10 seconds more than limit is weird", because + 604810 means + 7days, not +10 seconds 🤔

Copy link
Contributor

@SylvainSenechal SylvainSenechal Oct 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah nvm its
604810
not
604800
hard to spot, better to use things like 7 * 24 * 3600 + 10 but whatever, its nit you can leave it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants