-
Notifications
You must be signed in to change notification settings - Fork 252
Improvement/cldsrv 724 legacy related functional tests #5982
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: improvement/CLDSRV-724-mdSearch-related-functional-tests
Are you sure you want to change the base?
Conversation
❌ 4 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
063a9f4 to
296881d
Compare
ab4a359 to
db91a5a
Compare
5b3a4ed to
67b5ecb
Compare
| done(); | ||
| 'in the future', async () => { | ||
|
|
||
| // First, get a valid signed URL with maximum allowed expiry |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
| // First, get a valid signed URL with maximum allowed expiry | |
| // First, get a valid signed URL with maximum allowed expiry of 7 days |
then remove the other comment, or create a variable named 7daysInSec or something
Also the comment line 60 about the "10 seconds more than limit is weird", because + 604810 means + 7days, not +10 seconds 🤔
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ah nvm its
604810
not
604800
hard to spot, better to use things like 7 * 24 * 3600 + 10 but whatever, its nit you can leave it
Issue: CLDSRV-724