Improvement/cldsrv 724 versionning related functional tests #5978
+3,465
−3,826
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
❌ 54 Tests Failed:
View the top 3 failed test(s) by shortest run time
View the full list of 45 ❄️ flaky test(s)
To view more test analytics, go to the Test Analytics Dashboard |
benzekrimaha
force-pushed
the
improvement/CLDSRV-724-bucket-related-functional-tests
branch
3 times, most recently
from
834eefe to
92f36a8
Compare
benzekrimaha
force-pushed
the
improvement/CLDSRV-724-versionning-related-functional-tests
branch
from
f5f1929 to
84f6930
Compare
benzekrimaha
force-pushed
the
improvement/CLDSRV-724-bucket-related-functional-tests
branch
from
92f36a8 to
c1fb5b5
Compare
benzekrimaha
force-pushed
the
improvement/CLDSRV-724-versionning-related-functional-tests
branch
3 times, most recently
from
d0f6428 to
a680a09
Compare
benzekrimaha
force-pushed
the
improvement/CLDSRV-724-versionning-related-functional-tests
branch
2 times, most recently
from
2ce7329 to
9bdb532
Compare
| return s3.putObject({ | ||
| it('put objects inside bucket', async () => { | ||
| for (const obj of objects) { | ||
| // Handle versioning state changes |
There was a problem hiding this comment.
Suggested change
| // Handle versioning state changes |
| await s3.send(new PutBucketVersioningCommand(params)); | ||
| } | ||
|
|
||
| // Handle object operations |
There was a problem hiding this comment.
Suggested change
| // Handle object operations |
|
|
||
| // Handle object operations | ||
| if (obj.value === null) { | ||
| // For delete operations, we need to check the response headers |
There was a problem hiding this comment.
Suggested change
| // For delete operations, we need to check the response headers |
| it('should list object versions', async () => { | ||
| const key = 'key'; | ||
|
|
||
| // Put first version |
There was a problem hiding this comment.
Suggested change
| // Put first version |
| })); | ||
| const versionId1 = putResult1.VersionId; | ||
|
|
||
| // Put second version |
There was a problem hiding this comment.
Suggested change
| // Put second version |
| })); | ||
| const versionId2 = putResult2.VersionId; | ||
|
|
||
| // List versions |
There was a problem hiding this comment.
Suggested change
| // List versions |
| Body: 'body1', | ||
| })); | ||
|
|
||
| // Delete object (creates delete marker) |
There was a problem hiding this comment.
Suggested change
| // Delete object (creates delete marker) |
(same for other comments in the file)
Comment on lines
-70
to
-72
| { name: 'Pâtisserie=中文-español-English', value: 'foo' }, | ||
| { name: 'Pâtisserie=中文-español-English', value: 'bar' }, | ||
| { name: 'notes/spring/1.txt', value: 'qux' }, |
There was a problem hiding this comment.
are we stopping supporting object names like these? There is an advantage of keeping the special characters, as we do listing, it's to ensure it works well even when the object names are uncommon
| afterEach(async () => { | ||
| await removeAllVersions({ Bucket: bucketName }); | ||
| await s3.send(new DeleteBucketCommand({ Bucket: bucketName })); | ||
| // Create objects in batches of 20 concurrently |
There was a problem hiding this comment.
Suggested change
| // Create objects in batches of 20 concurrently |
DarkIsDude
approved these changes
Oct 28, 2025
| const config = getConfig('default', { signatureVersion: 'v4' }); | ||
| const s3 = new S3(config); | ||
| const config = getConfig('default'); | ||
|
|
| }; | ||
|
|
||
| async function customS3Request(CommandClass, params, buildParams) { | ||
| const customS3 = new S3Client({ ...config }); |
Comment on lines
+31
to
32
| function checkOneVersion(s3, bucket, versionId) { | ||
| return s3Client.send(new ListObjectVersionsCommand({ Bucket: bucket })).then(data => { |
There was a problem hiding this comment.
Suggested change
| function checkOneVersion(s3, bucket, versionId) { | |
| return s3Client.send(new ListObjectVersionsCommand({ Bucket: bucket })).then(data => { | |
| async function checkOneVersion(s3, bucket, versionId) { | |
| return await s3Client.send(new ListObjectVersionsCommand({ Bucket: bucket })).then(data => { |
This will keep the checkOneVersion in the stack trace. It's a "good" practice for async/await. But nits
|
|
||
| // empty and delete bucket after testing if bucket exists | ||
| afterEach(done => { | ||
| afterEach(done => { |
There was a problem hiding this comment.
Suggested change
| afterEach(done => { | |
| afterEach(done => { |
indentation ? Weird that the CI pass 😬
| return d; | ||
| } | ||
|
|
||
| function dateConvert(d) { |
There was a problem hiding this comment.
This helper seems really useful ?
| VersioningConfiguration: versioningSuspended, | ||
| })); | ||
|
|
||
| // List versions to check null version exists |
There was a problem hiding this comment.
I would delete comments as they just describe the test (same before)
DarkIsDude
approved these changes
Oct 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: CLDSRV-724