Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLDSRV-625: Multi ip kms kmip #5769

Open
wants to merge 5 commits into
base: development/7.70
Choose a base branch
from
Open

CLDSRV-625: Multi ip kms kmip #5769

wants to merge 5 commits into from

Conversation

BourgoisMickael
Copy link
Contributor

No description provided.

@BourgoisMickael
CLDSRV-625: No scality-kms warning if not conf
9261dc6 
Avoid print the warning if scality-kms is not configured:

```json
{"name":"S3","time":1742220545805,"error":{"code":"MODULE_NOT_FOUND","requireStack":["/home/mickael/scality/cloudserver/lib/kms/wrapper.js","/home/mickael/scality/cloudserver/lib/data/wrapper.js","/home/mickael/scality/cloudserver/lib/utilities/healthcheckHandler.js","/home/mickael/scality/cloudserver/lib/utilities/internalHandlers.js","/home/mickael/scality/cloudserver/lib/server.js","/home/mickael/scality/cloudserver/index.js"]},"level":"warn","message":"scality kms unavailable. Using file kms backend unless mem specified.","hostname":"mickael-xps","pid":139701}
```
@BourgoisMickael
CLDSRV-625: Fix kmip conf ca array
c0c4766 
The function uses `this`
It needed to be either bound or called on `this`
@BourgoisMickael
CLDSRV-625: Parse kmip config multi transport
aa1545e 
Provide a list of full transport object instead of only ip
@BourgoisMickael
CLDSRV-625: Bump arsenal for KMIP
5c935bc
@BourgoisMickael
CLDSRV-625: KMS wrapper handles multi ip KMIP
fb60589
@bert-e
Copy link
Contributor

bert-e commented Mar 20, 2025

Hello bourgoismickael,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval ⭐
/bypass_build_status Bypass the build and test status ⭐
/bypass_commit_size Bypass the check on the size of the changeset TBA ⭐
/bypass_incompatible_branch Bypass the check on the source branch prefix ⭐
/bypass_jira_check Bypass the Jira issue check ⭐
/bypass_peer_approval Bypass the pull request peers' approval ⭐
/bypass_leader_approval Bypass the pull request leaders' approval ⭐
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@scality scality deleted a comment from bert-e Mar 21, 2025
@scality scality deleted a comment from bert-e Mar 21, 2025
@bert-e
Copy link
Contributor

bert-e commented Mar 21, 2025

Request integration branches

Waiting for integration branch creation to be requested by the user.

To request integration branches, please comment on this pull request with the following command:

/create_integration_branches

Alternatively, the /approve and /create_pull_requests commands will automatically
create the integration branches.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nicolas2bert nicolas2bert nicolas2bert approved these changes

@jonathan-gramain jonathan-gramain Awaiting requested review from jonathan-gramain

@tmacro tmacro Awaiting requested review from tmacro

@dvasilas dvasilas Awaiting requested review from dvasilas

@fredmnl fredmnl Awaiting requested review from fredmnl

@williamlardier williamlardier Awaiting requested review from williamlardier

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BourgoisMickael @bert-e @nicolas2bert