-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support bigint during quota evaluation #5729
Conversation
Hello williamlardier,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
Incorrect fix versionThe
Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:
Please check the |
2948856
to
65bb1cd
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files
@@ Coverage Diff @@
## development/8.8 #5729 +/- ##
================================================
Coverage 64.46% 64.46%
================================================
Files 185 185
Lines 11638 11638
================================================
Hits 7502 7502
Misses 4136 4136
Flags with carried forward coverage won't be shown. Click here to find out more. |
afb9f7a
to
711e9b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
88d7910
to
ff28b66
Compare
cb57de0
to
d907318
Compare
34bb498
to
71e849f
Compare
/approve |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
09d09ca
to
3ebfd67
Compare
Issue: CLDSRV-606
- Value we get from vault is number, but converted into bigint internally - Value from the BucketInfo class is already bigint - Comparison will use the number received from Scuba as a bigint - Values may be imprecise but comparing with bigint ensures the comparison is correct as per the received values Issue: CLDSRV-606
3ebfd67
to
b606ed9
Compare
Integration data createdI have created the integration data for the additional destination branches.
The following branches will NOT be impacted:
You can set option
The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue CLDSRV-606. Goodbye williamlardier. The following options are set: approve |
Support comparing quotas using bigint, to reduce the impact of handling large numbers.
Issue: CLDSRV-606