Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support bigint during quota evaluation #5729

Merged
merged 6 commits into from
Jan 28, 2025
Merged

Conversation

williamlardier
Copy link
Contributor

@williamlardier williamlardier commented Jan 15, 2025

Support comparing quotas using bigint, to reduce the impact of handling large numbers.

Issue: CLDSRV-606

@bert-e
Copy link
Contributor

bert-e commented Jan 15, 2025

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@bert-e
Copy link
Contributor

bert-e commented Jan 15, 2025

Incorrect fix version

The Fix Version/s in issue CLDSRV-606 contains:

  • None

Considering where you are trying to merge, I ignored possible hotfix versions and I expected to find:

  • 8.8.41

  • 9.0.0

Please check the Fix Version/s of CLDSRV-606, or the target
branch of this pull request.

Copy link

codecov bot commented Jan 16, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.46%. Comparing base (d6bfe84) to head (b606ed9).
Report is 6 commits behind head on development/8.8.

✅ All tests successful. No failed tests found.

Additional details and impacted files

Impacted file tree graph

Files with missing lines Coverage Δ
lib/api/apiUtils/quotas/quotaUtils.js 89.81% <100.00%> (ø)
@@               Coverage Diff                @@
##           development/8.8    #5729   +/-   ##
================================================
  Coverage            64.46%   64.46%           
================================================
  Files                  185      185           
  Lines                11638    11638           
================================================
  Hits                  7502     7502           
  Misses                4136     4136           
Flag Coverage Δ
unit 64.46% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@williamlardier williamlardier force-pushed the bugfix/CLDSRV-606 branch 8 times, most recently from afb9f7a to 711e9b7 Compare January 16, 2025 15:46
@williamlardier williamlardier marked this pull request as ready for review January 17, 2025 12:49
Copy link
Contributor

@benzekrimaha benzekrimaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamlardier williamlardier force-pushed the bugfix/CLDSRV-606 branch 2 times, most recently from 88d7910 to ff28b66 Compare January 20, 2025 15:29
lib/api/api.js Outdated Show resolved Hide resolved
@williamlardier williamlardier marked this pull request as draft January 21, 2025 08:11
@williamlardier williamlardier force-pushed the bugfix/CLDSRV-606 branch 2 times, most recently from cb57de0 to d907318 Compare January 24, 2025 23:53
@williamlardier williamlardier force-pushed the bugfix/CLDSRV-606 branch 3 times, most recently from 34bb498 to 71e849f Compare January 25, 2025 01:14
@williamlardier
Copy link
Contributor Author

/approve

@williamlardier williamlardier marked this pull request as ready for review January 27, 2025 07:38
Copy link
Contributor

@benzekrimaha benzekrimaha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@williamlardier williamlardier force-pushed the bugfix/CLDSRV-606 branch 2 times, most recently from 09d09ca to 3ebfd67 Compare January 27, 2025 16:47
- Value we get from vault is number, but converted into bigint
  internally
- Value from the BucketInfo class is already bigint
- Comparison will use the number received from Scuba as a bigint
- Values may be imprecise but comparing with bigint ensures
  the comparison is correct as per the received values

Issue: CLDSRV-606
@scality scality deleted a comment from bert-e Jan 28, 2025
@bert-e
Copy link
Contributor

bert-e commented Jan 28, 2025

Integration data created

I have created the integration data for the additional destination branches.

  • this pull request will merge bugfix/CLDSRV-606 into
    development/8.8
  • w/9.0/bugfix/CLDSRV-606 will be merged into development/9.0

The following branches will NOT be impacted:

  • development/7.10
  • development/7.4
  • development/7.70

You can set option create_pull_requests if you need me to create
integration pull requests in addition to integration branches, with:

@bert-e create_pull_requests

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Jan 28, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.8

  • ✔️ development/9.0

The following branches have NOT changed:

  • development/7.10
  • development/7.4
  • development/7.70

Please check the status of the associated issue CLDSRV-606.

Goodbye williamlardier.

The following options are set: approve

@bert-e bert-e merged commit b606ed9 into development/8.8 Jan 28, 2025
19 checks passed
@bert-e bert-e deleted the bugfix/CLDSRV-606 branch January 28, 2025 11:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants