Skip to content

Improvement/zenko 4982 extra env vars secret specification #2210

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

benzekrimaha
Copy link
Contributor

@benzekrimaha benzekrimaha commented Apr 4, 2025

Issue: ZENKO-4982

@bert-e
Copy link
Contributor

bert-e commented Apr 4, 2025

Hello benzekrimaha,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

@benzekrimaha benzekrimaha force-pushed the improvement/ZENKO-4982-extraEnvVarsSecret-specification branch 2 times, most recently from b53ce06 to 063fb8b Compare April 4, 2025 14:18
@benzekrimaha benzekrimaha marked this pull request as ready for review April 4, 2025 14:18
@scality scality deleted a comment from bert-e Apr 4, 2025
@bert-e
Copy link
Contributor

bert-e commented Apr 4, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

@benzekrimaha benzekrimaha force-pushed the improvement/ZENKO-4982-extraEnvVarsSecret-specification branch 5 times, most recently from 44ca8ee to 5646550 Compare April 10, 2025 10:53
@benzekrimaha benzekrimaha force-pushed the improvement/ZENKO-4982-extraEnvVarsSecret-specification branch from 999e275 to f7649ba Compare April 14, 2025 12:42
This commit aims to simplify the process of managing secrets in the build process by
removing the patching of charts and instead directly including the secrets in the build.sh script.
Issue: ZENKO-4982
@benzekrimaha benzekrimaha force-pushed the improvement/ZENKO-4982-extraEnvVarsSecret-specification branch from f7649ba to a3f5dbf Compare April 14, 2025 12:42
@benzekrimaha
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Apr 14, 2025

Build failed

The build for commit did not succeed in branch improvement/ZENKO-4982-extraEnvVarsSecret-specification

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Apr 14, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/2.11

The following branches have NOT changed:

  • development/2.10
  • development/2.5
  • development/2.6
  • development/2.7
  • development/2.8
  • development/2.9

Please check the status of the associated issue ZENKO-4982.

Goodbye benzekrimaha.

The following options are set: approve

@bert-e bert-e merged commit a3f5dbf into development/2.11 Apr 14, 2025
15 checks passed
@bert-e bert-e deleted the improvement/ZENKO-4982-extraEnvVarsSecret-specification branch April 14, 2025 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants