-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARSN-479: Multi ip kms KMIP with simple round robin #2321
Conversation
Hello bourgoismickael,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
ping |
Request integration branchesWaiting for integration branch creation to be requested by the user. To request integration branches, please comment on this pull request with the following command:
Alternatively, the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed cloudserver PR as well.
Fix log ```json {"serverInformation":"[{\"Unknown Tag\":{\"type\":\"TextString\",\"value\":\"CipherTrust Manager\",\"tag\":\"420053\"}},{\"Unknown Tag\":{\"type\":\"TextString\",\"value\":\"2.18.0+13297\",\"tag\":\"541001\"}},{\"Unknown Tag\":{\"type\":\"TextString\",\"value\":\"CipherTrust Manager k170v\",\"tag\":\"541000\"}}]"} ``` Into ```json {"serverInformation":[{"Name":{"type":"TextString","value":"CipherTrust Manager"}},{"Extension Thales: version":{"type":"TextString","value":"2.18.0+13297"}},{"Extension Thales: model":{"type":"TextString","value":"CipherTrust Manager k170v"}}]} ```
So each client knows what method to implement
With simple round robin
Log the host for multi ip Log the latency for support to notice slow KMS problem Log the operation and the success of kmip request to know latency and host
a741353
to
8b0b191
Compare
/approve |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/8.1/improvement/ARSN-479-kms-ip origin/development/8.1
$ git merge origin/improvement/ARSN-479-kms-ip
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/8.1/improvement/ARSN-479-kms-ip The following options are set: approve |
ConflictA conflict has been raised during the creation of I have not created the integration branch. Here are the steps to resolve this conflict: $ git fetch
$ git checkout -B w/8.2/improvement/ARSN-479-kms-ip origin/development/8.2
$ git merge origin/w/8.1/improvement/ARSN-479-kms-ip
$ # <intense conflict resolution>
$ git commit
$ git push -u origin w/8.2/improvement/ARSN-479-kms-ip The following options are set: approve |
Build failedThe build for commit did not succeed in branch w/8.2/improvement/ARSN-479-kms-ip The following options are set: approve |
Build failedThe build for commit did not succeed in branch w/8.2/improvement/ARSN-479-kms-ip The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-479. Goodbye bourgoismickael. The following options are set: approve |
No description provided.