Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove count items dead code #2287

Merged
merged 1 commit into from
Mar 21, 2025
Merged

Remove count items dead code #2287

merged 1 commit into from
Mar 21, 2025

Conversation

williamlardier
Copy link
Contributor

  • MongoClientInterface still implements some duplicate (and outdated) logic implemented by count items in s3utils.
  • Dependency functions are removed, and tests cleaned accordingly.
  • Some functions were also wrong: checking the PENSIEVE collection to check for transient locations was relying on undefined field from a collection that is also not used anymore in Zenko 2. The logic itself is only related to statistics, currently overwritten by the count-items implementation. The Cloudserver logic around ops-metrics is unaffected, as it only uses the internal countItems function, used to read the count items results.
  • Transient locations are still supported as usual: they are unrelated to these functions.

I am expecting a functional test to fail in cloudserver after this change is merged, as the countItems function is functionally tested there.

Issue: ARSN-459

@bert-e
Copy link
Contributor

bert-e commented Feb 17, 2025

Hello williamlardier,

My role is to assist you with the merge of this
pull request. Please type @bert-e help to get information
on this process, or consult the user documentation.

Available options
name description privileged authored
/after_pull_request Wait for the given pull request id to be merged before continuing with the current one.
/bypass_author_approval Bypass the pull request author's approval
/bypass_build_status Bypass the build and test status
/bypass_commit_size Bypass the check on the size of the changeset TBA
/bypass_incompatible_branch Bypass the check on the source branch prefix
/bypass_jira_check Bypass the Jira issue check
/bypass_peer_approval Bypass the pull request peers' approval
/bypass_leader_approval Bypass the pull request leaders' approval
/approve Instruct Bert-E that the author has approved the pull request. ✍️
/create_pull_requests Allow the creation of integration pull requests.
/create_integration_branches Allow the creation of integration branches.
/no_octopus Prevent Wall-E from doing any octopus merge and use multiple consecutive merge instead
/unanimity Change review acceptance criteria from one reviewer at least to all reviewers
/wait Instruct Bert-E not to run until further notice.
Available commands
name description privileged
/help Print Bert-E's manual in the pull request.
/status Print Bert-E's current status in the pull request TBA
/clear Remove all comments from Bert-E from the history TBA
/retry Re-start a fresh build TBA
/build Re-start a fresh build TBA
/force_reset Delete integration branches & pull requests, and restart merge process from the beginning.
/reset Try to remove integration branches unless there are commits on them which do not appear on the source branch.

Status report is not available.

- MongoClientInterface still implements some duplicate (and outdated)
  logic implemented by count items in s3utils.
- Some dependency functions are removed, and tests cleaned
  accordingly.
- Some functions were also wrong: checking the PENSIEVE collection to
  check for transient locations was relying on undefined field from
  a collection that is not used anymore in Zenko 2. The logic itself
  is only related to statistics, currently overwritten by the
  count-items implementation.
- Transient locations are still supported as usual.

Issue: ARSN-459
@scality scality deleted a comment from bert-e Feb 17, 2025
@bert-e
Copy link
Contributor

bert-e commented Feb 17, 2025

Waiting for approval

The following approvals are needed before I can proceed with the merge:

  • the author

  • 2 peers

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 67.15%. Comparing base (6285cb7) to head (59a71d6).
Report is 63 commits behind head on development/8.2.

Additional details and impacted files
@@                 Coverage Diff                 @@
##           development/8.2    #2287      +/-   ##
===================================================
+ Coverage            66.79%   67.15%   +0.36%     
===================================================
  Files                  216      216              
  Lines                17452    17279     -173     
  Branches              3619     3580      -39     
===================================================
- Hits                 11657    11604      -53     
+ Misses                5791     5671     -120     
  Partials                 4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@scality scality deleted a comment from bert-e Mar 5, 2025
@williamlardier
Copy link
Contributor Author

/approve

@bert-e
Copy link
Contributor

bert-e commented Mar 21, 2025

In the queue

The changeset has received all authorizations and has been added to the
relevant queue(s). The queue(s) will be merged in the target development
branch(es) as soon as builds have passed.

The changeset will be merged in:

  • ✔️ development/8.2

The following branches will NOT be impacted:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.1

There is no action required on your side. You will be notified here once
the changeset has been merged. In the unlikely event that the changeset
fails permanently on the queue, a member of the admin team will
contact you to help resolve the matter.

IMPORTANT

Please do not attempt to modify this pull request.

  • Any commit you add on the source branch will trigger a new cycle after the
    current queue is merged.
  • Any commit you add on one of the integration branches will be lost.

If you need this pull request to be removed from the queue, please contact a
member of the admin team now.

The following options are set: approve

@bert-e
Copy link
Contributor

bert-e commented Mar 21, 2025

I have successfully merged the changeset of this pull request
into targetted development branches:

  • ✔️ development/8.2

The following branches have NOT changed:

  • development/6.4
  • development/7.10
  • development/7.4
  • development/7.70
  • development/8.1

Please check the status of the associated issue ARSN-459.

Goodbye williamlardier.

@bert-e bert-e merged commit b9dda0f into development/8.2 Mar 21, 2025
7 checks passed
@bert-e bert-e deleted the bugfix/ARSN-459 branch March 21, 2025 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants