-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove count items dead code #2287
Conversation
Hello williamlardier,My role is to assist you with the merge of this Available options
Available commands
Status report is not available. |
- MongoClientInterface still implements some duplicate (and outdated) logic implemented by count items in s3utils. - Some dependency functions are removed, and tests cleaned accordingly. - Some functions were also wrong: checking the PENSIEVE collection to check for transient locations was relying on undefined field from a collection that is not used anymore in Zenko 2. The logic itself is only related to statistics, currently overwritten by the count-items implementation. - Transient locations are still supported as usual. Issue: ARSN-459
0f44e4c
to
59a71d6
Compare
Waiting for approvalThe following approvals are needed before I can proceed with the merge:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## development/8.2 #2287 +/- ##
===================================================
+ Coverage 66.79% 67.15% +0.36%
===================================================
Files 216 216
Lines 17452 17279 -173
Branches 3619 3580 -39
===================================================
- Hits 11657 11604 -53
+ Misses 5791 5671 -120
Partials 4 4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
/approve |
In the queueThe changeset has received all authorizations and has been added to the The changeset will be merged in:
The following branches will NOT be impacted:
There is no action required on your side. You will be notified here once IMPORTANT Please do not attempt to modify this pull request.
If you need this pull request to be removed from the queue, please contact a The following options are set: approve |
I have successfully merged the changeset of this pull request
The following branches have NOT changed:
Please check the status of the associated issue ARSN-459. Goodbye williamlardier. |
countItems
function, used to read the count items results.I am expecting a functional test to fail in cloudserver after this change is merged, as the
countItems
function is functionally tested there.Issue: ARSN-459