refactor: list and OfferList vanilla extract #5698
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lisalupi
requested review from
fabienhebert and
vincentaudebert
and removed request for
a team
lisalupi
requested review from
a team
and removed request for
fabienhebert and
vincentaudebert
lisalupi
requested review from
DorianMaliszewski
and removed request for
a team
🦋 Changeset detectedLatest commit: b41c52d The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## beta #5698 +/- ##
========================================
Coverage 91.86% 91.86%
========================================
Files 308 318 +10
Lines 7299 7107 -192
Branches 2999 2889 -110
========================================
- Hits 6705 6529 -176
+ Misses 594 578 -16
... and 23 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
matthprost
requested changes
Oct 20, 2025
| <StyledRow | ||
| className={className} | ||
| <List.Row | ||
| className={`${className ? `${className} ` : ''} ${banner ? offerListRowBanner : ''}${isSelected ? `${offerListBanner ? ' ' : ''}${offerListRowSelected}` : ''}`} |
There was a problem hiding this comment.
Suggested change
| className={`${className ? `${className} ` : ''} ${banner ? offerListRowBanner : ''}${isSelected ? `${offerListBanner ? ' ' : ''}${offerListRowSelected}` : ''}`} | |
| className={`${className ? `${className} ` : ''}${banner ? offerListRowBanner : ''}${isSelected ? `${offerListBanner ? ' ' : ''}${offerListRowSelected}` : ''}`} |
| borderColor: theme.colors.primary.border, | ||
| }) | ||
|
|
||
| export const listCheckboxInRange = style({}) |
There was a problem hiding this comment.
not sure is it useful? I don't see the usage anywhere in the code 🤔
There was a problem hiding this comment.
In Row.ts (line193):
<Checkbox
aria-label="select"
checked={selectedRowIds[id]}
className={inRange?.includes(id) ? listCheckboxInRange : ''}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Type
Summarise concisely:
What is expected?
ListandOfferListto use vanilla-extract instead of EmotionminWith->minWidth