Skip to content

Conversation

lisalupi
Copy link
Collaborator

Summary

Type

  • Refactor

Summarise concisely:

UnitInput: remove && in style, since it is not needed anymore and replace id use with vanilla-extract class

@lisalupi lisalupi requested a review from a team October 15, 2025 13:01
@lisalupi lisalupi self-assigned this Oct 15, 2025
@lisalupi lisalupi requested review from alexandre-combemorel and matthprost and removed request for a team October 15, 2025 13:01
@lisalupi lisalupi requested a review from matthprost as a code owner October 15, 2025 13:01
@lisalupi lisalupi added the refactor Refactor without breaking changes label Oct 15, 2025
Copy link

changeset-bot bot commented Oct 15, 2025

🦋 Changeset detected

Latest commit: ad74075

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@ultraviolet/ui Minor
@ultraviolet/form Major
@ultraviolet/nextjs Major
@ultraviolet/plus Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

codecov bot commented Oct 15, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.86%. Comparing base (107fe0e) to head (ad74075).
⚠️ Report is 161 commits behind head on beta.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             beta    #5689      +/-   ##
==========================================
- Coverage   92.17%   91.86%   -0.31%     
==========================================
  Files         289      316      +27     
  Lines        7615     7144     -471     
  Branches     3149     2916     -233     
==========================================
- Hits         7019     6563     -456     
+ Misses        596      581      -15     
Files with missing lines Coverage Δ
packages/ui/src/components/UnitInput/styles.css.ts 100.00% <ø> (ø)

... and 77 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afe67bf...ad74075. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lisalupi lisalupi merged commit eb9e860 into beta Oct 21, 2025
16 of 17 checks passed
@lisalupi lisalupi deleted the fix/unit-input-css branch October 21, 2025 12:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

refactor Refactor without breaking changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants