Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Build and test on arm64 runner #4802

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Build and test on arm64 runner #4802

wants to merge 4 commits into from

Conversation

harryzcy
Copy link

@harryzcy harryzcy commented Feb 11, 2025 •
edited
Loading

@harryzcy harryzcy mentioned this pull request Feb 11, 2025
Closed
@kitbellew
Copy link
Collaborator

@aairey should we merge this, despite multiple failures?

@aairey
Copy link

aairey commented Feb 15, 2025

@aairey should we merge this, despite multiple failures?

I don't think so.

Someone who understands these test failures should take a look.

@kitbellew
Copy link
Collaborator

@aairey should we merge this, despite multiple failures?

I don't think so.

Someone who understands these test failures should take a look.

in that case, what was the purpose of approving this pr?

aairey
aairey reviewed Feb 15, 2025
View reviewed changes
Copy link

@aairey aairey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix test failures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aairey aairey aairey approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@harryzcy @kitbellew @aairey