Upgrade to Scala 3.7.1. #454
Conversation
| @@ -140,6 +140,7 @@ private[reader] object ClassfileParser { | |||
| val bytesArrArg = scalaSigAnnotation.values.head._2.asInstanceOf[AnnotationValue.Arr] | |||
| val idxs = bytesArrArg.values.map(_.asInstanceOf[AnnotationValue.Const].valueIdx) | |||
| pool.sigbytes(idxs) | |||
| case _: SimpleName => failNoAnnot() | |||
There was a problem hiding this comment.
This was reported as an inexhaustive match. I figured failing seemed reasonable but I'm happy to change it if you think there's a better option @sjrd
| @@ -31,9 +31,9 @@ private[pickles] class PickleReader { | |||
| private var frozenSymbols: Boolean = false | |||
|
|
|||
| /** The map from created local symbols to the address of their info, until it gets read. */ | |||
| private val localSymbolInfoRefs = mutable.AnyRefMap.empty[TermOrTypeSymbol, Int] | |||
| private val localSymbolInfoRefs = mutable.HashMap.empty[TermOrTypeSymbol, Int] | |||
There was a problem hiding this comment.
mutable.AnyRefMap was deprecated in scala/scala#10862 and now encourages use of mutable.HashMap
|
Happy to address the version policy failures, just not sure what the best way to do so is. Let me know |
See for example #449. |
Okay, I can do that, but what do you suggest for this error when running |
|
Just following up here @sjrd, do you have any suggestions for the Scala.js incompatibility issue? |
|
Hi @sjrd, wanted to follow up again. Now that the Scala 3.7.1 release is in progress I would love to push this over the finish line. For context, I'm trying to unblock the upgrade in a tool I built on top of tasty-query. What can I do to work around the reported Scala.js incompatibility issue? |
|
if the only message is i.e. it seems to be the fact that the scalajs std library bumped a minor, should that imply that the only solution is the |
AnyRefMap is deprecated in favor of HashMap in Scala 2.13.16. We have to work around sbt-version-policy not understand how the version of scalajs-scalalib works.
|
OK I figured out a way to prevent sbt-version-policy to report the false positive on the scalajs-scalalib. I took the liberty to rewrite the commit history in a way that is compatible with this repo's habits. |
|
Version 1.6.0 is on its way to Maven Central. Thanks for pushing this, and sorry for the lack of responsivity in the past few weeks. |
|
Thank you! |
Upgrades to Scala 3.7.0 and 2.13.16 for Scala 2 tests. Also upgrades Scala.js to 1.19.0 to match the compiler upgrade in scala/scala3#23026.