Skip to content

Fix task creation alignment #9142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
hotzenklotz merged 4 commits into from
Dec 16, 2025
Merged

Fix task creation alignment #9142

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8687bde
fix spacing
hotzenklotz Dec 10, 2025
3c93c68
add PR feedback
hotzenklotz Dec 12, 2025
39c8954
readme
hotzenklotz Dec 12, 2025
4182e5c
Merge branch 'master' into fix-task-create-spacing
hotzenklotz Dec 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
133 changes: 59 additions & 74 deletions frontend/javascripts/admin/task/task_create_form_view.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { InboxOutlined, ReloadOutlined, WarningOutlined } from "@ant-design/icons";
import { DownloadOutlined, InboxOutlined, ReloadOutlined } from "@ant-design/icons";
import { createTaskFromNML, createTasks, getTask, updateTask } from "admin/api/tasks";
import {
getActiveDatasetsOfMyOrganization,
Expand All @@ -15,11 +15,13 @@ import type {
} from "admin/task/task_create_bulk_view";
import { NUM_TASKS_PER_BATCH, normalizeFileEvent } from "admin/task/task_create_bulk_view";
import {
Alert,
App,
Button,
Card,
Col,
Divider,
Flex,
Form,
Input,
InputNumber,
Expand All @@ -29,6 +31,7 @@ import {
Select,
Spin,
Tooltip,
Typography,
Upload,
type UploadFile,
} from "antd";
Expand All @@ -37,9 +40,13 @@ import { AsyncButton } from "components/async_clickables";
import { formatDateInLocalTimeZone } from "components/formatted_date";
import SelectExperienceDomain from "components/select_experience_domain";
import { saveAs } from "file-saver";
import { coalesce, tryToAwaitPromise } from "libs/utils";
import { coalesce, pluralize, tryToAwaitPromise } from "libs/utils";
import { Vector3Input, Vector6Input } from "libs/vector_input";
import _ from "lodash";
import isEqual from "lodash/isEqual";
import isNil from "lodash/isNil";
import omit from "lodash/omit";
import omitBy from "lodash/omitBy";
import uniq from "lodash/uniq";
import messages from "messages";
import React, { useEffect, useState } from "react";
import { useNavigate, useParams } from "react-router-dom";
Expand Down Expand Up @@ -108,7 +115,7 @@ export function downloadTasksAsCSV(tasks: Array<APITask>) {
const lastCreationTime = Math.max(...tasks.map((task) => task.created));
const currentDateAsString = formatDateInLocalTimeZone(lastCreationTime, "YYYY-MM-DD_HH-mm");

const allProjectNames = _.uniq(tasks.map((task) => task.projectName)).join("_");
const allProjectNames = uniq(tasks.map((task) => task.projectName)).join("_");

const allTasksAsStrings = tasks.map((task) => taskToText(task)).join("\n");
const csv = [TASK_CSV_HEADER, allTasksAsStrings].join("\n");
Expand All @@ -128,9 +135,7 @@ export function handleTaskCreationResponse(
const successfulTasks: APITask[] = [];
const failedTasks: string[] = [];
let teamName: string | null = null;
const subHeadingStyle: React.CSSProperties = {
fontWeight: "bold",
};

const displayResultsStyle: React.CSSProperties = {
maxHeight: 300,
overflow: "auto",
Expand All @@ -148,7 +153,7 @@ export function handleTaskCreationResponse(
}
});

const allProjectNames = _.uniq(successfulTasks.map((task) => task.projectName));
const allProjectNames = uniq(successfulTasks.map((task) => task.projectName));

if (allProjectNames.length > 1) {
warnings.push(
Expand All @@ -159,73 +164,64 @@ export function handleTaskCreationResponse(
const warningsContent =
warnings.length > 0 ? (
<div>
<div style={subHeadingStyle}>
<WarningOutlined
style={{
color: "var(--ant-color-warning)",
}}
/>{" "}
There were warnings during task creation:
</div>
<div
style={{
whiteSpace: "pre-line",
}}
>
{warnings.join("\n")}
</div>
<Alert
showIcon
type="warning"
message="There were warnings during task creation"
description={warnings.join("\n")}
/>
</div>
) : null;

const failedTasksAsString = failedTasks.join("");
const successfulTasksContent =
successfulTasks.length <= maxDisplayedTasksCount ? (
<pre>
taskId,filename,position
<br />
{successfulTasks.map((task) => taskToShortText(task)).join("\n")}
</pre>
<Typography.Paragraph>
<pre>
taskId,filename,position
<br />
{successfulTasks.map((task) => taskToShortText(task)).join("\n")}
</pre>
</Typography.Paragraph>
) : (
"Too many tasks to show, please use the CSV download above for a full list."
);
const failedTasksContent =
failedTasks.length <= maxDisplayedTasksCount ? (
<pre>{failedTasksAsString}</pre>
<Typography.Paragraph>
<pre>{failedTasksAsString}</pre>
</Typography.Paragraph>
) : (
"Too many failed tasks to show, please use the CSV download for a full list."
);
const successPlural = successfulTasks.length === 1 ? "" : "s";
const warningsPlural = warnings.length === 1 ? "" : "s";

modal.info({
title: `${successfulTasks.length} task${successPlural} successfully created, ${failedTasks.length} failed. ${warnings.length} warning${warningsPlural}.`,
title: `${successfulTasks.length} ${pluralize("task", successfulTasks.length)} successfully created, ${failedTasks.length} ${pluralize("task", failedTasks.length)} failed. ${warnings.length} ${pluralize("warning", warnings.length)}.`,
content: (
<div>
{warningsContent}
{successfulTasks.length > 0 ? (
<div>
<div
style={{
display: "flex",
justifyContent: "center",
margin: 20,
}}
>
<Button onClick={() => downloadTasksAsCSV(successfulTasks)} type="primary">
<Flex justify="center" style={{ margin: 20 }}>
<Button
onClick={() => downloadTasksAsCSV(successfulTasks)}
type="primary"
icon={<DownloadOutlined />}
>
Download task info as CSV
</Button>
</div>
<div style={subHeadingStyle}> Successful Tasks: </div>
</Flex>
<Typography.Text strong>Successful Tasks:</Typography.Text>
<div style={displayResultsStyle}>{successfulTasksContent}</div>
</div>
) : null}
{failedTasks.length > 0 ? (
<React.Fragment>
<Divider />
<div>
<div
<Flex
justify="center"
style={{
display: "flex",
justifyContent: "center",
margin: 20,
}}
>
Expand All @@ -236,14 +232,13 @@ export function handleTaskCreationResponse(
});
saveAs(blob, "failed-tasks.csv");
}}
icon={<DownloadOutlined />}
>
Download failed task info as CSV
</Button>
</div>
<div style={subHeadingStyle}> Failed Tasks:</div>
</Flex>
<Typography.Text strong>Failed Tasks:</Typography.Text>
<div style={displayResultsStyle}> {failedTasksContent}</div>
<br />
<br />
</div>
</React.Fragment>
) : null}
Expand All @@ -255,18 +250,9 @@ export function handleTaskCreationResponse(

export function CreateResourceButton({ text, link }: { text: string; link: string }) {
return (
<Col span={4} style={{ marginTop: 11 }}>
<Col span={4} style={{ marginBottom: "var(--ant-form-item-margin-bottom)" }}>
<Button block href={link} target="_blank" rel="noreferrer">
<span
style={{
display: "block",
overflow: "hidden",
whiteSpace: "nowrap",
textOverflow: "ellipsis",
}}
>
{text}
</span>
{text}
</Button>
</Col>
);
Expand All @@ -280,9 +266,9 @@ export function ReloadResourceButton({
onReload: () => Promise<void>;
}) {
return (
<Col flex="40px">
<Col flex="40px" style={{ marginBottom: "var(--ant-form-item-margin-bottom)" }}>
<Tooltip title={tooltip}>
<AsyncButton style={{ marginTop: 7 }} icon={<ReloadOutlined />} onClick={onReload} />
<AsyncButton icon={<ReloadOutlined />} onClick={onReload} />
</Tooltip>
</Col>
);
Expand Down Expand Up @@ -349,7 +335,7 @@ function TaskCreateFormView() {
pendingInstances: task.status.pending,
});

const validFormValues = _.omitBy(defaultValues, _.isNil);
const validFormValues = omitBy(defaultValues, isNil);

// The task type is not needed for the form and leads to antd errors if it contains null values
const { type, ...neededFormValues } = validFormValues;
Expand All @@ -374,7 +360,7 @@ function TaskCreateFormView() {
if (taskId != null) {
// either update an existing task
const newTask = {
..._.omit(formValues, "nmlFiles", "baseAnnotation"),
...omit(formValues, "nmlFiles", "baseAnnotation"),
boundingBox,
};
const confirmedTask = await updateTask(taskId, newTask);
Expand All @@ -397,7 +383,7 @@ function TaskCreateFormView() {
const batchOfNmls = nmlFiles.slice(i, i + NUM_TASKS_PER_BATCH);

const newTask: NewNmlTask = {
..._.omit(formValues, "baseAnnotation"),
...omit(formValues, "baseAnnotation"),
boundingBox,
};
const response = await createTaskFromNML(newTask, batchOfNmls);
Expand All @@ -414,7 +400,7 @@ function TaskCreateFormView() {
: formValues.baseAnnotation;

const newTask = {
..._.omit(formValues, "nmlFiles", "baseAnnotation"),
...omit(formValues, "nmlFiles", "baseAnnotation"),
boundingBox,
baseAnnotation,
};
Expand All @@ -426,7 +412,7 @@ function TaskCreateFormView() {

handleTaskCreationResponse(modal, {
tasks: taskResponses,
warnings: _.uniq(warnings),
warnings: uniq(warnings),
});
} finally {
setIsUploading(false);
Expand Down Expand Up @@ -503,7 +489,7 @@ function TaskCreateFormView() {

if (
taskResponse?.datasetId != null &&
_.isEqual(taskResponse.status, {
isEqual(taskResponse.status, {
pending: 0,
active: 0,
finished: 1,
Expand All @@ -529,7 +515,7 @@ function TaskCreateFormView() {
</FormItem>
) : null}

<Row gutter={8} align="middle" wrap={false}>
<Row gutter={8} align="bottom" wrap={false}>
<Col flex="auto">
<FormItem
name="datasetId"
Expand Down Expand Up @@ -600,7 +586,6 @@ function TaskCreateFormView() {
const instancesLabel = isEditingMode ? "Remaining Instances" : "Task Instances";
return (
<div
className="container"
style={{
paddingTop: 20,
}}
Expand All @@ -616,7 +601,7 @@ function TaskCreateFormView() {
editRotation: [0, 0, 0],
}}
>
<Row gutter={8} align="middle" wrap={false}>
<Row gutter={8} align="bottom" wrap={false}>
<Col flex="auto">
<FormItem
name="taskTypeId"
Expand Down Expand Up @@ -649,7 +634,7 @@ function TaskCreateFormView() {
<CreateResourceButton text="Create new Task Type" link="/taskTypes/create" />
</Row>

<Row gutter={8} align="middle" wrap={false}>
<Row gutter={8} align="bottom" wrap={false}>
<Col span={10}>
<FormItem
name={["neededExperience", "domain"]}
Expand Down Expand Up @@ -706,7 +691,7 @@ function TaskCreateFormView() {
<InputNumber style={fullWidth} min={0} />
</FormItem>

<Row gutter={8} align="middle" wrap={false}>
<Row gutter={8} align="bottom" wrap={false}>
<Col flex="auto">
<FormItem
name="projectName"
Expand Down Expand Up @@ -739,7 +724,7 @@ function TaskCreateFormView() {
<CreateResourceButton text="Create new Project" link="/projects/create" />
</Row>

<Row gutter={8} align="middle" wrap={false}>
<Row gutter={8} align="bottom" wrap={false}>
<Col flex="auto">
<FormItem name="scriptId" label="Script" hasFeedback>
<Select
Expand Down
3 changes: 3 additions & 0 deletions unreleased_changes/9142.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
### Fixed
- Fixed spacing and layout of the task creation form.