Freshen all explicit arguments of type applications #24354
+214
−211
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, we did not do that, which means that explicit arguments in TypeApply's could not contain `^`. This precaution shoul dnot longer be needed with level checking.
Contributor
Author
|
Yichen, can you go through the changed test results and make sure that we don't introduce unsoundness anywhere? I already went over them but it's good to have a second pair of eyes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Map all
^s in explicit type arguments of TypeApply's to fresh caps. Previously, we did not do that, which means that explicit arguments in TypeApply's could not contain^.This precaution should no longer be needed with level checking.
Inferred arguments were already freshened before.