Add restricted capabilities x.only[C]
#23485
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prolativ
reviewed
Jul 7, 2025
| @@ -597,7 +597,7 @@ class SepCheck(checker: CheckCaptures.CheckerAPI) extends tpd.TreeTraverser: | |||
| * - If the reference is to a this type of the enclosing class, the | |||
| * access must be in a @consume method. | |||
| * | |||
| * References that extend SharedCapability are excluded from checking. | |||
| * References that extend cpas.Sharable are excluded from checking. | |||
There was a problem hiding this comment.
Suggested change
| * References that extend cpas.Sharable are excluded from checking. | |
| * References that extend caps.Sharable are excluded from checking. |
No more detour via PostfixOps of compiler-generated names.
Basic representations and definitions, so that we can parse only-capabilities, convert them to internal representation `Restrict(c, cls)`, not crash on them during capture checking and print them out correctly.
The previous version failed in the "Scala-3 with Capture Checking" test.
bracevac
reviewed
Jul 20, 2025
| * (x.rd)? = (x*)? | ||
| * (x?).reach = (x.reach)? | ||
| * (x.rd).reach = (x.reach).rd | ||
| * (x.only[T]).reach = (x*).only[T] |
There was a problem hiding this comment.
Suggested change
| * (x.only[T]).reach = (x*).only[T] | |
| * (x.only[T]).reach = (x.reach).only[T] |
or use .* consistently
bracevac
approved these changes
Jul 20, 2025
|
|
||
| /** The least classifier between `cls1` and `cls2`, which are either | ||
| * AnyClass, NothingClass, or a class directly extending caps.Classifier. | ||
| * @return if oen of cls1, cls2 is a subclass of the other, the subclass |
There was a problem hiding this comment.
Suggested change
| * @return if oen of cls1, cls2 is a subclass of the other, the subclass | |
| * @return if one of cls1, cls2 is a subclass of the other, the subclass |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation along the lines of #23463
only-capabilities.Classifierbase trait.only-capabilities.captureSetOfInfoforonlycapabilities.x.only[Nothing]. It should have emptycaptureSetOfInfo.onlymust refer to a classified capability class.- it's
*, then.only, then.rd,- multiple
.onlynormalize to the smallest one if the classes are related,- multiple
.onlynormalize to the empty capability if the classes are not related.FreshCapandResultCap.capToFreshandtoResultInResultsso that the classifier field is correctly set.tcs, define when a capability is classified by a classifier class.Ccan subsume only capabilities that are classified asC.-
c.as[C] <: difc <: dorc.as[D] <: empty-
c.as[C] <: d.as[D]ifc <: dandCderives fromD-
c <: d.as[D]ifc <: dandcis classified asD-
c.as[D] <: emptyiftcs(c)consists of capabilities that all derive from classifier classes unrelated toD.