Improve position of deprecation #23052
Merged
+43
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
som-snytt
force-pushed
the
issue/22795-msg-pos
branch
from
2eef13f to
d51cf92
Compare
som-snytt
changed the title
som-snytt
changed the title
lrytz
reviewed
Apr 29, 2025
| |--------------------------------------------------------------------------------------------------------------------- | ||
| |Inline stack trace | ||
| |- - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - | ||
| |This location contains code that was inlined from test_1.scala:5 |
There was a problem hiding this comment.
the code was inlined from lib_0.scala, not test_1.scala, or?
There was a problem hiding this comment.
yes, that was the improvement (to do) I mention in the comment. I hoped to book the progress before opening the can of worms. A can of worms has a long shelf life and can be opened at any time.
I'll improve the PR comment.
There was a problem hiding this comment.
note this is the (wrong) span it currently reports at.
lrytz
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #22795
This commit moves the caret to the site of inlining in the current file.
report.deprecationWarningomittedaddInlineds, which yields the "uninlined" position.It would be nice to correctly represent the inlined, spliced positions as well (which are shown in the explanation with the wrong file name, and which may be a source in a library).
It's clearly wrong to use a span from a different file, but the question remains how to represent a position from a dependency, which is not necessarily meaningful to the user.
This provisional tweak just shows the top-level splice location in the explanation, instead of what it quotes.