Use HTTP sbt repos for JDK6 #247
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cool! I guess if we've separately built/tested on JDK 6, then there's no downside to actually publishing from JDK 8...? |
This was referenced Jul 30, 2018
|
I don't know how publishing works. If it's HTTPS, it may be trouble. |
|
eh? I'm saying we should publish from JDK 8 |
|
Sorry, I hadn't seen your comment. I was just adding an additional comment on this PR, so it wasn't a response to your comment. I don't understand your JDK8 comment, but maybe discuss further on scala/sbt-scala-module#41? |
|
okay |
|
Thanks, Seth! |
gourlaysama
added a commit
to gourlaysama/scala-parser-combinators
that referenced
this pull request
Oct 8, 2018
Workaround the lack of TLS 1.2 support in JDK6 by using http to talk to maven central, as done in scala/scala-xml#247. See scala/sbt-scala-module#41. Fixes scala#169.
gourlaysama
added a commit
to gourlaysama/scala-parser-combinators
that referenced
this pull request
Oct 8, 2018
Workaround the lack of TLS 1.2 support in JDK6 by using http to talk to maven central, as done in scala/scala-xml#247. See scala/sbt-scala-module#41. Fixes scala#169.
Merged
|
This change has introduced a security vulnerability into this library. |
|
good point. let's discuss at scala/sbt-scala-module#41 rather than here, since multiple Scala modules are affected |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After #246, the build is broken for JDK6. This workaround fixes it by hard-coding HTTP repos for sbt.
This might be an alternative to upgrading to JDK7, see #237.
More information at scala/sbt-scala-module#41