Skip to content

add 'oraclejdk10' to Travis build matrix #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 28, 2018
Merged

add 'oraclejdk10' to Travis build matrix #235

merged 1 commit into from
Jun 28, 2018

Conversation

sullis
Copy link
Contributor

@sullis sullis commented Jun 25, 2018

No description provided.

@sullis
Copy link
Contributor Author

sullis commented Jun 25, 2018

lgtm

@ashawley
Copy link
Member

Looks good to me. Want to amend the commit and use the e-mail you use with GitHub?

$ git commit --amend --author 'Sean Sullivan <your@email>'

@ashawley
Copy link
Member

I've merged #229, so could you rebase with the latest master commits?

@ashawley
Copy link
Member

ashawley commented Jun 26, 2018 •
edited
Loading

Since, Java 9 support already ended in March 2018, maybe we should replace Java 9 with Java 10?
Essentially, Java 9 is really just a milestone on the way to the long-term release version, Java 12. This also keeps the build count down, so it runs in shorter time.

@ashawley ashawley added this to the 1.1.1 milestone Jun 26, 2018
@sullis sullis force-pushed the oraclejdk10-travis branch from 4d3c486 to 9be269f Compare June 26, 2018 13:23
@SethTisue
Copy link
Member

maybe we should replace Java 9 with Java 10

eventually, for sure. whether it's necessary to do so now, no strong opinion

@ashawley ashawley merged commit b26093d into scala:master Jun 28, 2018
@ashawley
Copy link
Member

Unfortunately, the build count has gone from 12 to 20. There's not really a big binary or source compatibility change in Java 10, unlike previous versions of Java where there was. We could add more exclusion rules in the Travis config, but I'm just going to follow-up with switching Java 9 for Java 10.

@ashawley ashawley mentioned this pull request Sep 21, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SethTisue SethTisue SethTisue approved these changes

@ashawley ashawley ashawley approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
1.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@sullis @ashawley @SethTisue