Annotations#9
Open
lsafina wants to merge 20 commits into
Open
Conversation
…n to avoid removing right away
…t (did not manage to get the logger working) Also added a 2 sec wait after starting to ensure the route has time to pick-up some work (not sure this actually contributes)
…hes a Boolean flag. When false, this flag prevents the Monitor from adding new routes (canWork guard)
…han 2) ports Added more monitor examples
Version change (1.6 --> 7) in pom.xml -- probably due to IntellIJ upgrade Additional printout in Switchable roots for ease of debugging
|
I'm using these in the VerCors support as well :) With some small changes because of VerCors shortcomings. Some small ideas we can maybe discuss next monday:
|
1) rename BIPCoordinator to GlueCoordinator, 2) add BIPException check in DataCoordinationKernel for register method, GlueCoordinatorImpl run and start methods 3) add informInternal, informSpontaneous methods skeletons
Owner
|
Hi all,
I support both proposals ;-) I had a look at repeatable annotations last
time we discussed it and, unless I misunderstood something, the change
would be really transparent for the existing JavaBIP code, since the
encompassing annotation is created automatically for the repeated ones.
Hence, I do not see any downside to using that.
Cheers,
Simon
…On Fri, 1 Jul 2022 at 11:51, Bob Rubbens ***@***.***> wrote:
I'm using these in the VerCors support as well :) With some small changes
because of VerCors shortcomings. Some small ideas we can maybe discuss next
monday:
- Should the argument name of @invariant <https://github.com/invariant>
be "value" instead of "expr"? Then you can use the annotations like, @invariant("x
> 2"), instead of @invariant(expr = "x > 2").
- I think this was already discussed but putting it here for
completeness: for the repeatable annotations (in particular I'm thinking of
@StatePredicates) maybe the PR can be refactored to use @repeatable?
This could also be useful for other JavaBIP annotations, e.g. @ports.
—
Reply to this email directly, view it on GitHub
<#9 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFKJQ2SD4Y6YLOBGEMCFMNLVR25T3ANCNFSM5PEI7B3Q>
.
You are receiving this because you are subscribed to this thread.Message
ID: ***@***.***>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Skeleton for @invariant(expr), @StatePredicate(state, expr) and and @pure annotations. Pre- and post-condition arguments added to @transition.