Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #35: fix batched sampling, fix tests. #36

Merged
merged 4 commits into from
Aug 20, 2024
Merged

fix #35: fix batched sampling, fix tests. #36

merged 4 commits into from
Aug 20, 2024

Conversation

janfb
Copy link
Contributor

@janfb janfb commented Aug 19, 2024 •
edited
Loading

fixes #35
fixes #31

@janfb janfb self-assigned this Aug 19, 2024
@janfb janfb linked an issue Aug 19, 2024 that may be closed by this pull request
refactor MDN class #31
Closed
@janfb janfb requested a review from michaeldeistler August 19, 2024 14:38
@janfb janfb mentioned this pull request Aug 19, 2024
Closed
michaeldeistler
michaeldeistler approved these changes Aug 20, 2024
View reviewed changes
Copy link
Contributor

@michaeldeistler michaeldeistler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Since you are probably a bit more into the code right now, it would be a great opportunity to add more detailed docstrings that outline the shapes in sample and log_prob here. But good to go either way!

@janfb janfb merged commit bf9e92b into main Aug 20, 2024
3 of 4 checks passed
@janfb janfb deleted the fix-batch-sampling branch August 20, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaeldeistler michaeldeistler michaeldeistler approved these changes

Assignees

@janfb janfb

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

MDN sampling not correct for batch size > 1 refactor MDN class
2 participants
@janfb @michaeldeistler