Draft
Conversation
oliverhaas
commented
Jan 12, 2026
| @@ -36,29 +36,30 @@ Repository = "https://github.com/sbdchd/celery-types" | |||
|
|
|||
| [dependency-groups] | |||
| dev = [ | |||
Contributor
Author
There was a problem hiding this comment.
These below are just alphabetically sorted now...
oliverhaas
commented
Jan 12, 2026
| [[ "${{ steps.stubtest-vine.outcome }}" == "failure" ]]; then | ||
| echo "One or more checks failed" | ||
| exit 1 | ||
| fi |
Contributor
Author
There was a problem hiding this comment.
The changes above make it a little bit easier to work with the CI. Instantly of failing fast one gets all the errors of the different checks at the end.
oliverhaas
commented
Jan 12, 2026
| celery.beat.ScheduleEntry.__le__ | ||
| celery.utils.timer2.Entry.__ge__ | ||
| celery.utils.timer2.Entry.__gt__ | ||
| celery.utils.timer2.Entry.__le__ |
Contributor
Author
There was a problem hiding this comment.
This and some of the other stuff in the ignore list can be removed with python 3.12+ or 3.14+, and I would move to python 3.14 soon-ish. But one after the other...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I suggest adding stubtest to the project to get more feedback in CI. This is not perfect, but overall pretty useful and commonly used by other type stub projects.
I will rebase this and mark as ready/not-draft once some other open PRs are taken care of.