Fix subprocess I/O descriptor leakage #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
are you sure you pushed the right commit ? i don't see any fix for io descriptor in process.py |
You are right that I did push the wrong commit! Let me fix it real quick. |
duynhaaa
force-pushed
the
fix-io-descriptor-leakage
branch
from
662cb93 to
ba1bc9b
Compare
|
I just pushed the correct commit this time. Please review and let me know if there's anything else that needs to be done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because
subprocess.Popenis used instead ofsubprocess.run, thestdoutandstderrstreams (bound to thesubprocess.Popenthroughsubprocess.PIPE) must be closed manually. Without doing so, the I/O descriptors held by them will not be released properly, causing the leakage.Update: I encountered this problem while running a custom script for a long time (at least 3-4 days).